UI tests of #342 without structural folder changes

.github/workflows/ui-tests.yml

@@ -0,0 +1,155 @@
+name: 'Run UI tests'
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+
+jobs:
+  build-summary:
+    runs-on: [ubuntu-latest]
+    name: Build summary UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the tests summary on the build summary page of a job
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=BuildSummaryTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
+
+  build-results:
+    runs-on: [ubuntu-latest]
+    name: Build results UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the detail view of failed unit tests of a build
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=BuildTestResultsTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
+
+  details:
+    runs-on: [ubuntu-latest]
+    name: Details UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the detail view of a failed JUnit test
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=TestDetailTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
+
+  publisher:
+    runs-on: [ubuntu-latest]
+    name: Publisher UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Cache local Maven repository
+        uses: actions/[email protected]
+        with:
+          path: ~/.m2/repository
+          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-maven-
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the job configuration of the JUnit test results report publisher
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=JobConfigurationTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
+
+  job-overview:
+    runs-on: [ubuntu-latest]
+    name: Job overview UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the the published results of JUnit tests on the job summary page
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=JobConfigurationTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
+
+  class-filter:
+    runs-on: [ubuntu-latest]
+    name: Filtered by class UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the unit tests results of a build which are filtered by a class
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=BuildTestResultsByClassTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1
+
+  package-filter:
+    runs-on: [ubuntu-latest]
+    name: Filtered by package UI tests
+
+    steps:
+      - uses: actions/[email protected]
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          distribution: 'temurin'
+          java-version: '11'
+          check-latest: true
+          cache: 'maven'
+      - name: Build junit plugin and download dependencies
+        run: mvn -V -ntp verify -Pskip --file plugin/pom.xml -Dgpg.skip
+      - name: Run UI tests for the unit tests results of a build which are filtered by a package
+        env:
+          BROWSER: firefox-container
+        run: mvn -V -ntp test --file ui-tests/pom.xml -Dtest=BuildTestResultsByPackageTest -Dgpg.skip -Dsurefire.rerunFailingTestsCount=1

Jenkinsfile

@@ -1 +1,4 @@
-buildPlugin(useContainerAgent: true, platforms: ['linux'])
+def configurations = [
+  [ platform: "docker", jdk: "11" ]
+]
+buildPlugin(configurations: configurations)

plugin/.mvn/extensions.xml

@@ -2,6 +2,6 @@
   <extension>
     <groupId>io.jenkins.tools.incrementals</groupId>
     <artifactId>git-changelist-maven-extension</artifactId>
-    <version>1.2</version>
+    <version>1.3</version>
   </extension>
 </extensions>

plugin/pom.xml

@@ -13,10 +13,10 @@
     <description>Allows JUnit-format test results to be published.</description>
     <url>https://github.com/jenkinsci/junit-plugin</url>
     <properties>
-        <revision>1.54</revision>
+        <revision>1.56</revision>
         <changelist>-SNAPSHOT</changelist>
         <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
-        <jenkins.version>2.263.1</jenkins.version>
+        <jenkins.version>2.321</jenkins.version>
         <java.level>8</java.level>
         <no-test-jar>false</no-test-jar>
     </properties>
@@ -30,7 +30,7 @@
         <connection>scm:git:git://github.com/${gitHubRepo}.git</connection>
         <developerConnection>scm:git:[email protected]:${gitHubRepo}.git</developerConnection>
         <url>https://github.com/${gitHubRepo}</url>
-      <tag>${scmTag}</tag>
+        <tag>${scmTag}</tag>
     </scm>
     <repositories>
         <repository>
@@ -70,7 +70,7 @@
         <dependency>
             <groupId>io.jenkins.plugins</groupId>
             <artifactId>github-checks</artifactId>
-            <version>1.0.13</version>
+            <version>1.0.16</version>
             <scope>test</scope>
         </dependency>
         <dependency>
@@ -150,7 +150,7 @@
         <dependency>
             <groupId>org.jenkins-ci.plugins</groupId>
             <artifactId>database</artifactId>
-            <version>117.va2009e38b882</version>
+            <version>128.vaa83e142f7f2</version>
             <scope>test</scope>
             <exclusions>
                 <exclusion> <!-- TODO move to bom in Jenkins core -->
@@ -191,16 +191,16 @@
         <dependencies>
             <dependency>
                 <groupId>io.jenkins.tools.bom</groupId>
-                <artifactId>bom-2.263.x</artifactId>
-                <version>961.vf0c9f6f59827</version>
+                <artifactId>bom-2.303.x</artifactId>
+                <version>1117.v62a_f6a_01de98</version>
                 <scope>import</scope>
                 <type>pom</type>
             </dependency>
             <!-- mockito and hibernate are conflicting (both test dependencies) -->
             <dependency>
                 <groupId>net.bytebuddy</groupId>
                 <artifactId>byte-buddy</artifactId>
-                <version>1.12.3</version>
+                <version>1.12.8</version>
             </dependency>
         </dependencies>
     </dependencyManagement>

plugin/src/main/java/hudson/tasks/junit/CaseResult.java

@@ -42,8 +42,8 @@
 import org.kohsuke.stapler.Stapler;
 import org.kohsuke.stapler.export.Exported;
 
-import javax.annotation.CheckForNull;
-import javax.annotation.Nonnull;
+import edu.umd.cs.findbugs.annotations.CheckForNull;
+import edu.umd.cs.findbugs.annotations.NonNull;
 import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;
@@ -653,7 +653,7 @@ public String getFlowNodeId() {
         return null;
     }
 
-    @Nonnull
+    @NonNull
     public List<String> getEnclosingFlowNodeIds() {
         List<String> enclosing = new ArrayList<>();
         if (parent != null) {
@@ -662,7 +662,7 @@ public List<String> getEnclosingFlowNodeIds() {
         return enclosing;
     }
 
-    @Nonnull
+    @NonNull
     public List<String> getEnclosingFlowNodeNames() {
         List<String> enclosing = new ArrayList<>();
         if (parent != null) {

plugin/src/main/java/hudson/tasks/junit/JUnitResultArchiver.java

@@ -59,7 +59,7 @@
 import org.kohsuke.stapler.DataBoundSetter;
 import org.kohsuke.stapler.QueryParameter;
 
-import javax.annotation.Nonnull;
+import edu.umd.cs.findbugs.annotations.NonNull;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Collections;
@@ -138,15 +138,15 @@ public JUnitResultArchiver(
     }
 
     @Deprecated
-    private TestResult parse(String expandedTestResults, Run<?,?> run, @Nonnull FilePath workspace, Launcher launcher, TaskListener listener)
+    private TestResult parse(String expandedTestResults, Run<?,?> run, @NonNull FilePath workspace, Launcher launcher, TaskListener listener)
             throws IOException, InterruptedException
     {
         return parse(this, null, expandedTestResults, run, workspace, launcher, listener);
 
     }
 
-    private static TestResult parse(@Nonnull JUnitTask task, PipelineTestDetails pipelineTestDetails,
-                                    String expandedTestResults, Run<?,?> run, @Nonnull FilePath workspace,
+    private static TestResult parse(@NonNull JUnitTask task, PipelineTestDetails pipelineTestDetails,
+                                    String expandedTestResults, Run<?,?> run, @NonNull FilePath workspace,
                                     Launcher launcher, TaskListener listener)
             throws IOException, InterruptedException {
         return new JUnitParser(task.isKeepLongStdio(), task.isAllowEmptyResults())
@@ -174,7 +174,7 @@ public void perform(Run build, FilePath workspace, Launcher launcher,
 
     /** @deprecated use {@link #parseAndSummarize} instead */
     @Deprecated
-    public static TestResultAction parseAndAttach(@Nonnull JUnitTask task, PipelineTestDetails pipelineTestDetails,
+    public static TestResultAction parseAndAttach(@NonNull JUnitTask task, PipelineTestDetails pipelineTestDetails,
                                                   Run build, FilePath workspace, Launcher launcher, TaskListener listener)
             throws InterruptedException, IOException {
         listener.getLogger().println(Messages.JUnitResultArchiver_Recording());
@@ -231,7 +231,7 @@ public static TestResultAction parseAndAttach(@Nonnull JUnitTask task, PipelineT
         }
     }
 
-    public static TestResultSummary parseAndSummarize(@Nonnull JUnitTask task, PipelineTestDetails pipelineTestDetails,
+    public static TestResultSummary parseAndSummarize(@NonNull JUnitTask task, PipelineTestDetails pipelineTestDetails,
                                                   Run<?, ?> build, FilePath workspace, Launcher launcher, TaskListener listener)
             throws InterruptedException, IOException {
         JunitTestResultStorage storage = JunitTestResultStorage.find();
@@ -352,7 +352,7 @@ public double getHealthScaleFactor() {
         this.healthScaleFactor = Math.max(0.0, healthScaleFactor);
     }
 
-    @Nonnull
+    @NonNull
     @Override
     public List<TestDataPublisher> getTestDataPublishers() {
         return testDataPublishers == null ? Collections.emptyList() : testDataPublishers;
@@ -363,7 +363,7 @@ public List<TestDataPublisher> getTestDataPublishers() {
      *
      * @since 1.2
      */
-    @DataBoundSetter public final void setTestDataPublishers(@Nonnull List<TestDataPublisher> testDataPublishers) {
+    @DataBoundSetter public final void setTestDataPublishers(@NonNull List<TestDataPublisher> testDataPublishers) {
         this.testDataPublishers = new DescribableList<>(Saveable.NOOP);
         this.testDataPublishers.addAll(testDataPublishers);
     }

plugin/src/main/java/hudson/tasks/junit/SuiteResult.java

@@ -35,8 +35,8 @@
 import org.kohsuke.stapler.export.ExportedBean;
 import org.xml.sax.SAXException;
 
-import javax.annotation.CheckForNull;
-import javax.annotation.Nonnull;
+import edu.umd.cs.findbugs.annotations.CheckForNull;
+import edu.umd.cs.findbugs.annotations.NonNull;
 import java.io.File;
 import java.io.FileInputStream;
 import java.io.IOException;
@@ -331,7 +331,7 @@ public String getNodeId() {
      * @since 1.22
      */
     @Exported(visibility=9)
-    @Nonnull
+    @NonNull
     public List<String> getEnclosingBlocks() {
         if (enclosingBlocks != null) {
             return Collections.unmodifiableList(enclosingBlocks);
@@ -346,7 +346,7 @@ public List<String> getEnclosingBlocks() {
      * @since 1.22
      */
     @Exported(visibility=9)
-    @Nonnull
+    @NonNull
     public List<String> getEnclosingBlockNames() {
         if (enclosingBlockNames != null) {
             return Collections.unmodifiableList(enclosingBlockNames);

plugin/src/main/java/hudson/tasks/junit/TestDataPublisher.java

@@ -33,7 +33,7 @@
 import jenkins.model.Jenkins;
 
 import java.io.IOException;
-import javax.annotation.Nonnull;
+import edu.umd.cs.findbugs.annotations.NonNull;
 
 /**
  * Contributes {@link TestAction}s to test results.
@@ -69,7 +69,7 @@ public abstract class TestDataPublisher extends AbstractDescribableImpl<TestData
      * @since 1.2-beta-1
      */
 	public TestResultAction.Data contributeTestData(
-			Run<?,?> run, @Nonnull FilePath workspace, Launcher launcher,
+			Run<?,?> run, @NonNull FilePath workspace, Launcher launcher,
 			TaskListener listener, TestResult testResult) throws IOException, InterruptedException {
         if (run instanceof AbstractBuild && listener instanceof BuildListener) {
             return getTestData((AbstractBuild) run, launcher, (BuildListener) listener, testResult);