Skip to content

-Pktunnel#2815

Merged
jglick merged 1 commit intojenkinsci:masterfrom
jglick:ktunnel
Mar 25, 2026
Merged

-Pktunnel#2815
jglick merged 1 commit intojenkinsci:masterfrom
jglick:ktunnel

Conversation

@jglick
Copy link
Copy Markdown
Member

@jglick jglick commented Mar 14, 2026 •
edited
Loading

Following up #1593 with an even easier way to use the tunnel from the CLI.

@jglick jglick requested a review from a team as a code owner March 14, 2026 13:45
@jglick jglick added the chore Maintenance label Mar 14, 2026
jglick
jglick commented Mar 14, 2026
View reviewed changes
pom.xml
Comment on lines -297 to -298
<hudson.slaves.NodeProvisioner.initialDelay>0</hudson.slaves.NodeProvisioner.initialDelay>
<hudson.slaves.NodeProvisioner.recurrencePeriod>3000</hudson.slaves.NodeProvisioner.recurrencePeriod>
Copy link
Copy Markdown
Member Author

@jglick jglick Mar 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be necessary as of #598.

History: f3c43b7 357355f (from #217) #898

jglick
jglick commented Mar 14, 2026
View reviewed changes
pom.xml
Comment on lines -311 to -313
<hudson.slaves.NodeProvisioner.initialDelay>0</hudson.slaves.NodeProvisioner.initialDelay>
<hudson.slaves.NodeProvisioner.MARGIN>50</hudson.slaves.NodeProvisioner.MARGIN>
<hudson.slaves.NodeProvisioner.MARGIN0>0.85</hudson.slaves.NodeProvisioner.MARGIN0>
Copy link
Copy Markdown
Member Author

@jglick jglick Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

jglick
jglick commented Mar 14, 2026
View reviewed changes
pom.xml
<systemPropertyVariables>
<jenkins.host.address>jenkins.default.svc.cluster.local</jenkins.host.address>
<port>8000</port>
<slaveAgentPort>8001</slaveAgentPort>
Copy link
Copy Markdown
Member Author

@jglick jglick Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note inconsistency:

kubernetes-plugin/src/test/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesTestUtil.java

Lines 137 to 141 in b59f230

// TODO could just use standard jenkins.model.Jenkins.slaveAgentPort and skip this code (also in SetupCloud):
Integer slaveAgentPort = Integer.getInteger("slaveAgentPort");
if (slaveAgentPort != null) {
Jenkins.get().setSlaveAgentPort(slaveAgentPort);
}

@jglick jglick requested a review from jtnord March 17, 2026 14:04
apuig
apuig approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown

@apuig apuig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ergonomics. I ran some tests with -Pktunnel and ./kind.sh : all fine.
Thanks!

@jglick jglick merged commit a82d78a into jenkinsci:master Mar 25, 2026
10 checks passed
@jglick jglick deleted the ktunnel branch March 25, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtnord jtnord Awaiting requested review from jtnord

1 more reviewer

@apuig apuig apuig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jglick @apuig