Fix incorrect trace output upon file closing#132
Open
jglick wants to merge 5 commits intojenkinsci:masterfrom
Open
Fix incorrect trace output upon file closing#132jglick wants to merge 5 commits intojenkinsci:masterfrom
jglick wants to merge 5 commits intojenkinsci:masterfrom
Conversation
Previously when a file close callback is invoked, the dumped trace is not the closing stacktrace, but the opening stacktrace. This PR fixes this issue by creating a new FileRecord instance.
…etector into fix-close-display
timja
approved these changes
Mar 3, 2023
NotMyFault
approved these changes
Mar 16, 2023
timja
approved these changes
May 29, 2023
…etector into fix-close-display
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#38 with merge conflicts resolved.