Streamable http transport fix #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implementation seems to work - Unit test is broken on client/server protocol issue
… to route request with stream endpoint to StreamableEndpoint, ensure using correct protocolVersion as default returned is 2024-11-05 which was not included streamble Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
olamy
commented
Aug 4, 2025
| public String protocolVersion() { | ||
| // FIXME this should be done in sdk itself as returning "2024-11-05" | ||
| // looks wrong for streamable | ||
| // see https://github.com/modelcontextprotocol/java-sdk/pull/441 |
There was a problem hiding this comment.
modelcontextprotocol/java-sdk#441
will need changes with next release of the java-sdl
hellosaumil
reviewed
Aug 4, 2025
| "servers": { | ||
| "jenkins": { | ||
| "type": "http", | ||
| "url": "https://jenkins-host/mcp-server/streamable", |
There was a problem hiding this comment.
We should be using /mcp url since that's the standard url followed by other MCP servers at large, too. Thanks!
|
closing in favour of #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix implementation from PR #25