Skip to content

Conversation

batmat
Copy link
Member

@batmat batmat commented Oct 21, 2025

This is useful for the end user to understand that the call was trigger through this plugin's code and not some manual user intervention. And among others, it allows plugins like buildtriggerbadge to offer custom badges.

Testing done

Before this change, if you trigger the build through the MCP Server, this would show this (because the code was using "UserIdCause")

image

With this change

image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch! (opened from my own fork and dedicated branch)
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira (didn't create one, as this sounded like a very small change, but happy to create one if needed)
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed (manually tested, but I can write an automated test if desired)

@batmat batmat requested a review from a team as a code owner October 21, 2025 14:15
@batmat
Copy link
Member Author

batmat commented Oct 21, 2025

🤔 Now I realize that keeping also the username who is using the MCP server would be important. I'll modify the PR.

@olamy olamy marked this pull request as draft October 22, 2025 00:47
@olamy
Copy link
Member

olamy commented Oct 22, 2025

🤔 Now I realize that keeping also the username who is using the MCP server would be important. I'll modify the PR.

moved it to draft for now

@batmat batmat marked this pull request as ready for review October 22, 2025 06:42
> Medium: A null pointer returned by a method risks being dereferenced in new io.jenkins.plugins.mcp.server.extensions.DefaultMcpServer$MCPCause()
  [io.jenkins.plugins.mcp.server.extensions.DefaultMcpServer$MCPCause, io.jenkins.plugins.mcp.server.extensions.DefaultMcpServer$MCPCause] Dereferenced at
  DefaultMcpServer.java:[line 101] Known null at DefaultMcpServer.java:[line 101] NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants