Skip to content

Update inconsistent style for environment and build steps #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ridemountainpig wants to merge 1 commit into from
+15 −11
Closed

Update inconsistent style for environment and build steps #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/main/resources/jenkins/plugins/nodejs/NodeJSBuildWrapper/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,13 @@ THE SOFTWARE.
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
<f:entry title="${%nodeJSInstallationName.title}" description="${%nodeJSInstallationName.description}">
<select class="setting-input" name="_.nodeJSInstallationName">
<j:forEach var="inst" items="${descriptor.installations}">
<f:option selected="${inst.name==instance.nodeJSInstallationName}">${inst.name}</f:option>
</j:forEach>
</select>
<div class="jenkins-select">
<select class="jenkins-select__input" name="_.nodeJSInstallationName">
<j:forEach var="inst" items="${descriptor.installations}">
<f:option selected="${inst.name==instance.nodeJSInstallationName}">${inst.name}</f:option>
</j:forEach>
</select>
</div>
</f:entry>

<f:entry title="${%configId.title}">
Expand Down
14 changes: 8 additions & 6 deletions src/main/resources/jenkins/plugins/nodejs/NodeJSCommandInterpreter/config.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,14 @@ THE SOFTWARE.
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
<f:entry title="${%nodeJSInstallationName.title}" description="${%nodeJSInstallationName.description}">
<select class="setting-input" name="_.nodeJSInstallationName">
<f:option value="">${%nodeJSInstallationName.emptyValue}</f:option>
<j:forEach var="inst" items="${descriptor.installations}">
<f:option selected="${inst.name==instance.nodeJSInstallationName}">${inst.name}</f:option>
</j:forEach>
</select>
<div class="jenkins-select">
<select class="jenkins-select__input" name="_.nodeJSInstallationName">
<f:option value="">${%nodeJSInstallationName.emptyValue}</f:option>
<j:forEach var="inst" items="${descriptor.installations}">
<f:option selected="${inst.name==instance.nodeJSInstallationName}">${inst.name}</f:option>
</j:forEach>
</select>
</div>
</f:entry>

<f:entry title="${%command.title}" description="See &lt;a href='${rootURL}/env-vars.html' target=_new>the list of available environment variables&lt;/a> accessible by process.env.ENV_VARIABLE.">
Expand Down