Enable toggleOffOn feature for spotless#1123
Merged
timja merged 1 commit intojenkinsci:masterfrom May 1, 2025
strangelookingnerd:patch-1
Merged
Enable toggleOffOn feature for spotless#1123timja merged 1 commit intojenkinsci:masterfrom strangelookingnerd:patch-1
toggleOffOn feature for spotless#1123timja merged 1 commit intojenkinsci:masterfrom
strangelookingnerd:patch-1
Conversation
1 task
timja
approved these changes
Apr 16, 2025
Member
|
The affected code involved (We could hard-code a version of the formatter in this POM, but then we would need to find a way to keep it up to date.) |
Member
I have vague memories of us hitting this before (specifically the per language different default versions)
I'm sure renovate can handle it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into some cases where the formatting of
com.diffplug.spotless:spotless-maven-pluginsimply did not produce satisfying results.There is a feature that allows comments to toggle spotless formatting on and off (disabled by default):
While I can override the config in my plugin
pom.xmlI don't see a reason to not enable the feature by default here.Testing done
Manually verified that changes have no impact if the feature is not being used.
Submitter checklist