Skip to content

Declare formatter version to avoid spotless choosing a version #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkEWaite merged 1 commit into from
Jun 26, 2025
Merged

Declare formatter version to avoid spotless choosing a version #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,11 @@
<indent>
<spaces>true</spaces>
</indent>
<palantirJavaFormat />
<palantirJavaFormat>
<!-- Declare version so that spotless does not choose a version based on JDK version -->
<!-- https://github.com/diffplug/spotless/issues/2503#issuecomment-2953146277 -->
Copy link
Member

@jglick jglick Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diffplug/spotless#2503 (comment)

<version>2.67.0</version>
Copy link
Member

@jglick jglick Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this version number coming from? It does not seem to match https://github.com/diffplug/spotless/blob/2d32ccd3ef17e80f456f7bd3587846f2734bca71/lib/src/main/java/com/diffplug/spotless/java/PalantirJavaFormatStep.java#L32 (diffplug/spotless#2447 picking up palantir/palantir-java-format#1211).

Copy link
Member

@jglick jglick Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the point is merely that this is some arbitrary recent version, rather than picking one of two distinct much older versions depending on the JRE.

Copy link
Contributor Author

@MarkEWaite MarkEWaite Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the most recent release of palantir-java-format as of the day that I created this pull request, as reported by https://mvnrepository.com/artifact/com.palantir.javaformat/palantir-java-format . Sadly, a newer release arrived the day after this commit was created and then another release happened several weeks after that.

Copy link
Member

@jglick jglick Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem I think, just confirming.

</palantirJavaFormat>
<removeUnusedImports />
<toggleOffOn />
<trimTrailingWhitespace />
Expand Down