Added environment variable functionality by vikulin · Pull Request #117 · jenkinsci/s3-plugin

vikulin · 2018-10-11T20:16:20Z

Added new functionality

environment variable can receive artifacts URLs

2. added S3 pre-signed URL publish option

# Conflicts: # src/main/java/hudson/plugins/s3/S3BucketPublisher.java

2. copyartifacts methods fix

vikulin · 2020-05-03T14:33:27Z

This helpful change has been implemented accordingly to my production CI server task. I needed to send published s3 links to Slack channel. As result I have implemented these functionality using InjectEnvPlugin. Please review my work.

Thanks.

vikulin · 2021-04-23T15:44:20Z

Any updates?

vikulin · 2021-04-23T15:45:46Z

@olivergondza , can you please review my pull request?

vikulin · 2021-04-23T15:48:07Z

vikulin · 2021-07-28T00:23:55Z

@alecharp, can you please review my changes?

Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 961.vf0c9f6f59827 to 1008.vb9e22885c9cf. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.289.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.16.0 to 1.16.2. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.16.0...1.16.2) --- updated-dependencies: - dependency-name: org.testcontainers:testcontainers dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [aws-java-sdk-minimal](https://github.com/jenkinsci/aws-java-sdk-plugin) from 1.12.80 to 1.12.101-300.vc09c7be9cb57. - [Release notes](https://github.com/jenkinsci/aws-java-sdk-plugin/releases) - [Changelog](https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/aws-java-sdk-plugin@aws-java-sdk-parent-1.12.80...1.12.101-300.vc09c7be9cb57) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

vikulin · 2021-11-19T14:15:50Z

@rsandell , please review my changes.

alecharp

Thank you for your contribution. However, the current PR has a lot of noise, which is distracting from reviewing it's purpose. Please, see my few comments and once addressed, I'll review the core of the PR.

pom.xml

.project

src/main/java/hudson/plugins/s3/ClientHelper.java

src/main/java/hudson/plugins/s3/Destination.java

src/main/java/hudson/plugins/s3/Entry.java

src/main/java/hudson/plugins/s3/S3BucketPublisher.java

src/main/java/hudson/plugins/s3/Uploads.java

src/main/resources/hudson/plugins/s3/Entry/config.jelly

src/main/java/hudson/plugins/s3/S3BucketPublisher.java

Bumps [maven-plugin](https://github.com/jenkinsci/maven-plugin) from 3.18 to 3.19. - [Release notes](https://github.com/jenkinsci/maven-plugin/releases) - [Changelog](https://github.com/jenkinsci/maven-plugin/blob/master/CHANGELOG.md) - [Commits](jenkinsci/maven-plugin@maven-plugin-3.18...maven-plugin-3.19) --- updated-dependencies: - dependency-name: org.jenkins-ci.main:maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…ain-maven-plugin-3.19 Bump maven-plugin from 3.18 to 3.19

Bumps [aws-java-sdk-minimal](https://github.com/jenkinsci/aws-java-sdk-plugin) from 1.12.215-339.vdc07efc5320c to 1.12.246-349.v96b_b_f7eb_a_c3c. - [Release notes](https://github.com/jenkinsci/aws-java-sdk-plugin/releases) - [Changelog](https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/CHANGELOG.md) - [Commits](https://github.com/jenkinsci/aws-java-sdk-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [testcontainers](https://github.com/testcontainers/testcontainers-java) from 1.17.2 to 1.17.3. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/master/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.17.2...1.17.3) --- updated-dependencies: - dependency-name: org.testcontainers:testcontainers dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.40 to 4.42. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.40...plugin-4.42) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1409.v7659b_c072f18 to 1472.vb_65d893c9a_b_6. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.289.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

….bom-bom-2.289.x-1472.vb_65d893c9a_b_6 Bump bom-2.289.x from 1409.v7659b_c072f18 to 1472.vb_65d893c9a_b_6

…lugins-plugin-4.42 Bump plugin from 4.40 to 4.42

Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1472.vb_65d893c9a_b_6 to 1478.v81d3dc4f9a_43. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.289.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

….bom-bom-2.289.x-1478.v81d3dc4f9a_43 Bump bom-2.289.x from 1472.vb_65d893c9a_b_6 to 1478.v81d3dc4f9a_43

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.42 to 4.43.1. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.42...plugin-4.43.1) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…lugins-plugin-4.43.1 Bump plugin from 4.42 to 4.43.1

Bumps [bom-2.289.x](https://github.com/jenkinsci/bom) from 1478.v81d3dc4f9a_43 to 1500.ve4d05cd32975. - [Release notes](https://github.com/jenkinsci/bom/releases) - [Commits](https://github.com/jenkinsci/bom/commits) --- updated-dependencies: - dependency-name: io.jenkins.tools.bom:bom-2.289.x dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>

….bom-bom-2.289.x-1500.ve4d05cd32975 Bump bom-2.289.x from 1478.v81d3dc4f9a_43 to 1500.ve4d05cd32975

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.43.1 to 4.45. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.43.1...plugin-4.45) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [envinject](https://github.com/jenkinsci/envinject-plugin) from 2.866.v5c0403e3d4df to 2.875.v9b_9e962da_a_ec. - [Release notes](https://github.com/jenkinsci/envinject-plugin/releases) - [Changelog](https://github.com/jenkinsci/envinject-plugin/blob/master/docs/CHANGELOG_OLD.md) - [Commits](https://github.com/jenkinsci/envinject-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:envinject dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…lugins-plugin-4.45 Bump plugin from 4.43.1 to 4.45

…lugins-envinject-2.875.v9b_9e962da_a_ec Bump envinject from 2.866.v5c0403e3d4df to 2.875.v9b_9e962da_a_ec

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.45 to 4.46. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.45...plugin-4.46) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…lugins-plugin-4.46 Bump plugin from 4.45 to 4.46

Bumps [copyartifact](https://github.com/jenkinsci/copyartifact-plugin) from 1.46.4 to 1.47. - [Release notes](https://github.com/jenkinsci/copyartifact-plugin/releases) - [Changelog](https://github.com/jenkinsci/copyartifact-plugin/blob/master/CHANGELOG.adoc) - [Commits](jenkinsci/copyartifact-plugin@copyartifact-1.46.4...copyartifact-1.47) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:copyartifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…lugins-copyartifact-1.47 Bump copyartifact from 1.46.4 to 1.47

…rs-testcontainers-1.17.3 Bump testcontainers from 1.17.2 to 1.17.3

…lugins.aws-java-sdk-aws-java-sdk-minimal-1.12.246-349.v96b_b_f7eb_a_c3c Bump aws-java-sdk-minimal from 1.12.215-339.vdc07efc5320c to 1.12.246-349.v96b_b_f7eb_a_c3c

Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.20.0 to 5.20.1. - [Release notes](https://github.com/release-drafter/release-drafter/releases) - [Commits](release-drafter/release-drafter@v5.20.0...v5.20.1) --- updated-dependencies: - dependency-name: release-drafter/release-drafter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…-drafter/release-drafter-5.20.1 Bump release-drafter/release-drafter from 5.20.0 to 5.20.1

Bumps [plugin](https://github.com/jenkinsci/plugin-pom) from 4.46 to 4.47. - [Release notes](https://github.com/jenkinsci/plugin-pom/releases) - [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md) - [Commits](jenkinsci/plugin-pom@plugin-4.46...plugin-4.47) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins:plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…lugins-plugin-4.47 Bump plugin from 4.46 to 4.47

Bumps [aws-java-sdk-minimal](https://github.com/jenkinsci/aws-java-sdk-plugin) from 1.12.246-349.v96b_b_f7eb_a_c3c to 1.12.287-357.vf82d85a_6eefd. - [Release notes](https://github.com/jenkinsci/aws-java-sdk-plugin/releases) - [Changelog](https://github.com/jenkinsci/aws-java-sdk-plugin/blob/master/CHANGELOG.md) - [Commits](https://github.com/jenkinsci/aws-java-sdk-plugin/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

…lugins.aws-java-sdk-aws-java-sdk-minimal-1.12.287-357.vf82d85a_6eefd Bump aws-java-sdk-minimal from 1.12.246-349.v96b_b_f7eb_a_c3c to 1.12.287-357.vf82d85a_6eefd

vikulin added 11 commits October 11, 2018 12:24

1. added variable injection of artifacts url

fad1063

1. fixed parameters saving

b518906

1. added help

db45483

1. fixed test constructor

6e78429

1. added help file

8a00444

1. help file fix

4fd67de

1. cosmetic fix

0e72621

1. fixed S3 download link

9dcdb98

2. added S3 pre-signed URL publish option

Merge branch 'master' of https://github.com/jenkinsci/s3-plugin

39d8af5

# Conflicts: # src/main/java/hudson/plugins/s3/S3BucketPublisher.java

1. import fix

e5a4159

2. copyartifacts methods fix

1. fixed deprecated code errors

20584d3

vikulin closed this May 3, 2020

vikulin reopened this May 3, 2020

1. space fix

bb41b6f

1. corrected AWS URLs

7fa3243

vikulin and others added 8 commits November 19, 2021 14:25

Merged changes from parent repo

b9ea463

Merge branch 'jenkinsci-master' into HEAD

783da0d

Merge branch 'jenkinsci-master-1'

e45cc55

1. added secure domain link

af33517

removed unused method

30c0000

alecharp requested changes Nov 19, 2021

View reviewed changes

dependabot bot and others added 30 commits June 2, 2022 08:26

Merge pull request #61 from vikulin/dependabot/maven/org.jenkins-ci.m…

4ee30f1

…ain-maven-plugin-3.19 Bump maven-plugin from 3.18 to 3.19

Merge pull request #71 from vikulin/dependabot/maven/io.jenkins.tools…

3e2d383

….bom-bom-2.289.x-1472.vb_65d893c9a_b_6 Bump bom-2.289.x from 1409.v7659b_c072f18 to 1472.vb_65d893c9a_b_6

Merge pull request #70 from vikulin/dependabot/maven/org.jenkins-ci.p…

28575d5

…lugins-plugin-4.42 Bump plugin from 4.40 to 4.42

Merge pull request #72 from vikulin/dependabot/maven/io.jenkins.tools…

c2d146c

….bom-bom-2.289.x-1478.v81d3dc4f9a_43 Bump bom-2.289.x from 1472.vb_65d893c9a_b_6 to 1478.v81d3dc4f9a_43

Merge pull request #73 from vikulin/dependabot/maven/org.jenkins-ci.p…

f17cd30

…lugins-plugin-4.43.1 Bump plugin from 4.42 to 4.43.1

Merge pull request #74 from vikulin/dependabot/maven/io.jenkins.tools…

a0d5ad8

….bom-bom-2.289.x-1500.ve4d05cd32975 Bump bom-2.289.x from 1478.v81d3dc4f9a_43 to 1500.ve4d05cd32975

Merge pull request #76 from vikulin/dependabot/maven/org.jenkins-ci.p…

47bd1c2

…lugins-plugin-4.45 Bump plugin from 4.43.1 to 4.45

Merge pull request #77 from vikulin/dependabot/maven/org.jenkins-ci.p…

685cb9d

…lugins-envinject-2.875.v9b_9e962da_a_ec Bump envinject from 2.866.v5c0403e3d4df to 2.875.v9b_9e962da_a_ec

Merge pull request #78 from vikulin/dependabot/maven/org.jenkins-ci.p…

6739efe

…lugins-plugin-4.46 Bump plugin from 4.45 to 4.46

Merge pull request #79 from vikulin/dependabot/maven/org.jenkins-ci.p…

1732a88

…lugins-copyartifact-1.47 Bump copyartifact from 1.46.4 to 1.47

Merge pull request #68 from vikulin/dependabot/maven/org.testcontaine…

ddca990

…rs-testcontainers-1.17.3 Bump testcontainers from 1.17.2 to 1.17.3

Merge pull request #65 from vikulin/dependabot/maven/org.jenkins-ci.p…

4764866

…lugins.aws-java-sdk-aws-java-sdk-minimal-1.12.246-349.v96b_b_f7eb_a_c3c Bump aws-java-sdk-minimal from 1.12.215-339.vdc07efc5320c to 1.12.246-349.v96b_b_f7eb_a_c3c

Merge pull request #80 from vikulin/dependabot/github_actions/release…

4a623f7

…-drafter/release-drafter-5.20.1 Bump release-drafter/release-drafter from 5.20.0 to 5.20.1

Merge pull request #81 from vikulin/dependabot/maven/org.jenkins-ci.p…

172315e

…lugins-plugin-4.47 Bump plugin from 4.46 to 4.47

Merge pull request #82 from vikulin/dependabot/maven/org.jenkins-ci.p…

6ecc873

…lugins.aws-java-sdk-aws-java-sdk-minimal-1.12.287-357.vf82d85a_6eefd Bump aws-java-sdk-minimal from 1.12.246-349.v96b_b_f7eb_a_c3c to 1.12.287-357.vf82d85a_6eefd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added environment variable functionality#117

Added environment variable functionality#117
vikulin wants to merge 115 commits intojenkinsci:masterfrom
vikulin:master

vikulin commented Oct 11, 2018 •

edited

Loading

Uh oh!

vikulin commented May 3, 2020

Uh oh!

vikulin commented Apr 23, 2021

Uh oh!

vikulin commented Apr 23, 2021

Uh oh!

vikulin commented Apr 23, 2021

Uh oh!

vikulin commented Jul 28, 2021

Uh oh!

vikulin commented Nov 19, 2021

Uh oh!

alecharp left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vikulin commented Oct 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikulin commented May 3, 2020

Uh oh!

vikulin commented Apr 23, 2021

Uh oh!

vikulin commented Apr 23, 2021

Uh oh!

vikulin commented Apr 23, 2021

Uh oh!

vikulin commented Jul 28, 2021

Uh oh!

vikulin commented Nov 19, 2021

Uh oh!

alecharp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vikulin commented Oct 11, 2018 •

edited

Loading