Support configurable checksum algorithms for s3 uploads#367
Open
prathamalwayscomeslast wants to merge 7 commits intojenkinsci:masterfrom
Open
Support configurable checksum algorithms for s3 uploads#367prathamalwayscomeslast wants to merge 7 commits intojenkinsci:masterfrom
prathamalwayscomeslast wants to merge 7 commits intojenkinsci:masterfrom
Conversation
Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
…ling test Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
Author
|
@rsandell for this change, I have added the related unit test here but I've been running into too many pitfalls with that, NoSuchKey errors and such. And I am unsure how to move forward with that, I'd really appreciate any guidance on this :) However, I have manually tested this on S3 bucket with different algorithms, most work as expected. So will this be safe to merge? |
Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
Signed-off-by: PRATHAM ~ <prathamcomeslast@gmail.com>
Member
|
Well I don't know enough to give any definite answer, but the first thing I see is that the line where the test fails is in code that seems to do some jenkins calls under the hood but outside of a running jenkins instance, i.e. not inside |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes JENKINS-71836
Checksum algorithms are now configurable with this change, with CRC32 as the default.
Testing done
Manually tested checksumAlgorithm: 'CRC32C', 'SHA256', 'SHA1' and 'CRC32' s3 uploads and all show correct, corresponding checksum functions in S3.
Note
CRC64NVME algorithm led to unstable build and failed uploads as it requires aws crt dependency, so it is currently marked as unsupported.
Submitter checklist