Skip to content

Migrate tests to JUnit5 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate tests to JUnit5 #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions src/test/java/io/jenkins/plugins/safebatch/BatchSanitizerGlobalRuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
*/
package io.jenkins.plugins.safebatch;

import static org.junit.Assert.fail;
import static org.junit.Assume.assumeTrue;
import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.Assumptions.assumeTrue;

import hudson.Functions;
import hudson.model.Build;
Expand All @@ -39,17 +39,23 @@
import hudson.tasks.BatchFile;
import io.jenkins.plugins.environment_filter_utils.matchers.run.ExactJobFullNameRunMatcher;
import jenkins.tasks.filters.EnvVarsFilterGlobalConfiguration;
import org.junit.Rule;
import org.junit.Test;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.jvnet.hudson.test.JenkinsRule;
import org.jvnet.hudson.test.junit.jupiter.WithJenkins;

public class BatchSanitizerGlobalRuleTest {
@WithJenkins
class BatchSanitizerGlobalRuleTest {

@Rule
public JenkinsRule j = new JenkinsRule();
private JenkinsRule j;

@BeforeEach
void setUp(JenkinsRule rule) {
j = rule;
}

@Test
public void globalRule_canBe_ignoreForGivenJobs() throws Exception {
void globalRule_canBe_ignoreForGivenJobs() throws Exception {
assumeTrue(Functions.isWindows());

EnvVarsFilterGlobalConfiguration.getAllActivatedGlobalRules().clear();
Expand Down