-
Notifications
You must be signed in to change notification settings - Fork 172
[JENKINS-68404] Add script listener to track usage #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
meiswjn
wants to merge
14
commits into
jenkinsci:master
Choose a base branch
from
meiswjn:feature/add-script-listener
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6e29f5f
Add script listener to track usage
meiswjn e7bb854
Fix imports
meiswjn d947485
Remove redundant code
meiswjn b9eafc1
Fix docstring
meiswjn e69d7cb
Remove NonNull from Run for compatibility
meiswjn df3ee0e
Improve compatibility by generalizing origin to String
meiswjn 7b433d5
Simplify listener by extending from Jenkins
meiswjn cf6ae25
Remove unnecessary imports
meiswjn 6bd9763
Merge branch 'master' into feature/add-script-listener
meiswjn abfbc35
Adapt to new scriptlistener format
meiswjn 44b395b
Merge branch 'master' into feature/add-script-listener
meiswjn aa41a17
Use incremental
daniel-beck 4582926
Make build
daniel-beck 81eef7b
We need to build on JDK 11
daniel-beck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/main/java/org/jenkinsci/plugins/scriptsecurity/scripts/ScriptListener.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| package org.jenkinsci.plugins.scriptsecurity.scripts; | ||
|
|
||
| import hudson.ExtensionPoint; | ||
| import hudson.model.Run; | ||
| import jenkins.util.Listeners; | ||
|
|
||
| /** | ||
| * A listener to track usage of Groovy scripts running outside of a sandbox. | ||
| * | ||
| * @see org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript#evaluate(ClassLoader, groovy.lang.Binding, hudson.model.TaskListener) | ||
| */ | ||
| public interface ScriptListener extends ExtensionPoint { | ||
|
|
||
| /** | ||
| * Called when a groovy script is executed in a pipeline outside of a sandbox. | ||
| * | ||
| * @see org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript#evaluate(ClassLoader, groovy.lang.Binding, hudson.model.TaskListener) | ||
| * @param script The Groovy script that is excecuted. | ||
| * @param run The run calling the Groovy script. | ||
| */ | ||
| void onScriptFromPipeline(String script, Run run); | ||
|
|
||
| /** | ||
| * Fires the {@link #onScriptFromPipeline(String, Run)} event to track the usage of groovy scripts running outside the sandbox. | ||
| * | ||
| * @see org.jenkinsci.plugins.scriptsecurity.sandbox.groovy.SecureGroovyScript#evaluate(ClassLoader, groovy.lang.Binding, hudson.model.TaskListener) | ||
| * @param script The Groovy script that is excecuted. | ||
| * @param run The run calling the Groovy script. | ||
| */ | ||
| static void fireScriptFromPipelineEvent(String script, Run run) { | ||
| Listeners.notify(ScriptListener.class, true, listener -> listener.onScriptFromPipeline(script, run)); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.