Skip to content

Use local mock server instead of jenkins.io in ScriptApprovalTest#forceSandboxTests #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jglick merged 4 commits into from
Feb 4, 2026
Merged

Use local mock server instead of jenkins.io in ScriptApprovalTest#forceSandboxTests #913

jglick merged 4 commits into from
Feb 4, 2026

Conversation

@nevingeorgesunny
Copy link
Contributor

@nevingeorgesunny nevingeorgesunny commented Feb 4, 2026 •
edited
Loading

The ScriptApprovalTest#forceSandboxTests currently relies on a live connection to https://www.jenkins.io/. During the recent site outage, this dependency caused builds to fail.

This PR uses a mock url thus removing external dependencies

@nevingeorgesunny nevingeorgesunny changed the title Refactoring force sandbox tests Use local mock server instead of jenkins.io in ScriptApprovalTest#forceSandboxTests Feb 4, 2026
@nevingeorgesunny nevingeorgesunny marked this pull request as ready for review February 4, 2026 07:08
@nevingeorgesunny nevingeorgesunny requested a review from a team as a code owner February 4, 2026 07:08
jglick
jglick reviewed Feb 4, 2026
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but does not cover classpathEntriesEscaped as seen in #912. To test, please turn off Internet connection (I just put my laptop in airplane mode) and mvn test.

@lemeurherve
Copy link
Member

lemeurherve commented Feb 4, 2026 •
edited
Loading

Thanks!

FTR,

@nevingeorgesunny
Copy link
Contributor Author

nevingeorgesunny commented Feb 4, 2026

OK but does not cover classpathEntriesEscaped as seen in #912. To test, please turn off Internet connection (I just put my laptop in airplane mode) and mvn test.

sorry , saw the example.com thought it was a placeholder . yes it was still breaking when offline.
i updated the classpathEntriesEscaped test to also use the mock url .

ran a mvn test when offline all test are passing

jglick
jglick approved these changes Feb 4, 2026
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jglick jglick mentioned this pull request Feb 4, 2026
Closed
@jglick jglick merged commit e6a6654 into jenkinsci:master Feb 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick approved these changes

Assignees

No one assigned

Labels

developer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nevingeorgesunny @lemeurherve @jglick