we may have received a tcp FIN. in such case we should establish a new connection. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w connection. If the syslog server have closed the connection it will send a TCP FIN. Current ensureSyslogServerConnection() implementation only check the socket state. Those checks don't cover the TCP FIN case. In order to check it, we should try and read from the socket. If a FIN was sent, read() will return -1. In such case we should mark the socket as invalid, and reconnect. If we won't, the next message we'll send will be rejected with a RST. No exception thrown outside to the caller, and no indication that the message was lost.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the syslog server have closed the connection it will send a TCP FIN. Current ensureSyslogServerConnection() implementation only check the socket state. Those checks don't cover the TCP FIN case.
In order to check it, we should try and read from the socket. If a FIN was sent, read() will return -1.
In such case we should mark the socket as invalid, and reconnect. If we won't, the next message we'll send will be rejected with a RST. No exception thrown outside to the caller, and no indication that the message was lost.
to reproduce: