Skip to content

Add @Symbol("publishTap") to TapPublisher Descriptor and pipeline test#44

Merged
kinow merged 2 commits intojenkinsci:masterfrom
0xShubhamSolanki:add-publishTap-symbol
Feb 26, 2026
Merged

Add @Symbol("publishTap") to TapPublisher Descriptor and pipeline test#44
kinow merged 2 commits intojenkinsci:masterfrom
0xShubhamSolanki:add-publishTap-symbol

Conversation

@0xShubhamSolanki
Copy link

@0xShubhamSolanki 0xShubhamSolanki commented Feb 21, 2026

Fixes JENKINS-43785

Description

This pull request adds the @Symbol("publishTap") annotation to the TapPublisher descriptor.
With this change, the step can now be used directly in Pipeline scripts as:

publishTap(testResults: 'test.log')

Previously, the publisher did not expose a Pipeline symbol, which made its usage in Pipeline jobs less straightforward.
A small Pipeline test has also been added to confirm that the symbol is properly registered and works in a WorkflowJob.

Testing done

  • Ran mvn clean verify locally and confirmed all tests pass.
  • Added a new TapPublisherPipelineTest to ensure the publishTap step works in a Pipeline job.
  • Verified that the build completes successfully in the test environment.

This change does not modify existing behavior, only exposes the publisher through a Pipeline symbol and adds a corresponding test.

@0xShubhamSolanki
Copy link
Author

Hi, just a gentle follow-up on this PR.
This implements the suggested @symbol("publishTap") and adds a Pipeline test.
All checks are passing.

Could someone please review when available?
Thanks!

@kinow
Copy link
Member

kinow commented Feb 23, 2026

Hi @0xShubhamSolanki ! Sorry, I looked at the code last week, but I also had to release Active Choices (doing a masters, so I'm trying to optimize my spare time the best I can).

I was going to comment only if it'd be OK if I push a commit (which I will squash later, keeping yours) to add the newline at the end of some of the new files that are missing that, and the licence header to the new source code that's missing that too.

I'd do that, ask you to review, squash, merge, and release. Let me know what you think. Thanks for the patience! 🙇

@0xShubhamSolanki
Copy link
Author

Hi @kinow,
Thanks a lot for reviewing the PR — and no worries at all!
That sounds perfect. Please feel free to push the updates for the newline and license header. I’ll review the changes once they’re in.
Really appreciate your help with this.

@kinow
Copy link
Member

kinow commented Feb 24, 2026

Hi @kinow, Thanks a lot for reviewing the PR — and no worries at all! That sounds perfect. Please feel free to push the updates for the newline and license header. I’ll review the changes once they’re in. Really appreciate your help with this.

Great, thanks @0xShubhamSolanki ! Let me just find a time this week to sync my code and apply these changes. Please, have a look at @MarkEWaite 's comments too 👍 Thanks!

@0xShubhamSolanki
Copy link
Author

Thanks for the review and feedback.
The Pipeline test has been updated to create a valid TAP file in the workspace before invoking publishTap. It now verifies actual behavior instead of only symbol resolution. Please let me know if any further refinements are needed.

Copy link

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kinow kinow force-pushed the add-publishTap-symbol branch from 6b1f015 to ac3a4d9 Compare February 26, 2026 13:14
@kinow
Copy link
Member

kinow commented Feb 26, 2026

Added changelog entry & credit, updated license year to 2026 (thanks for adding it @0xShubhamSolanki !), added missing newline at the end of files, squashed changes. Waiting for the pipeline to run. I can merge it soon, and then cut a release tonight if everything works 👍

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kinow kinow merged commit 029bd43 into jenkinsci:master Feb 26, 2026
15 checks passed
@kinow
Copy link
Member

kinow commented Feb 26, 2026

I may hold back on releasing it for a few days just to see if I can include this one, #43

@0xShubhamSolanki
Copy link
Author

0xShubhamSolanki commented Feb 26, 2026

@kinow @MarkEWaite Thanks for the review and guidance on this PR. I really appreciate the feedback and the opportunity to contribute.
I’m planning to stay actively involved with Jenkins this year and would be glad to help further. If there are specific areas where help is needed, I’d appreciate any suggestions.

@kinow
Copy link
Member

kinow commented Feb 26, 2026

Great to hear you will stick around! I'd say look for issues or new features you think are fun or you will learn something. I believe all plugins devs appreciate help. Or look at jenkins core and other libs in Jenkins. There's a lot to have fuj and learn! Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants