Add @Symbol("publishTap") to TapPublisher Descriptor and pipeline test#44
Conversation
|
Hi, just a gentle follow-up on this PR. Could someone please review when available? |
|
Hi @0xShubhamSolanki ! Sorry, I looked at the code last week, but I also had to release Active Choices (doing a masters, so I'm trying to optimize my spare time the best I can). I was going to comment only if it'd be OK if I push a commit (which I will squash later, keeping yours) to add the newline at the end of some of the new files that are missing that, and the licence header to the new source code that's missing that too. I'd do that, ask you to review, squash, merge, and release. Let me know what you think. Thanks for the patience! 🙇 |
|
Hi @kinow, |
Great, thanks @0xShubhamSolanki ! Let me just find a time this week to sync my code and apply these changes. Please, have a look at @MarkEWaite 's comments too 👍 Thanks! |
|
Thanks for the review and feedback. |
6b1f015 to
ac3a4d9
Compare
|
Added changelog entry & credit, updated license year to 2026 (thanks for adding it @0xShubhamSolanki !), added missing newline at the end of files, squashed changes. Waiting for the pipeline to run. I can merge it soon, and then cut a release tonight if everything works 👍 |
kinow
left a comment
There was a problem hiding this comment.
LGTM, thanks @0xShubhamSolanki , @MarkEWaite
|
I may hold back on releasing it for a few days just to see if I can include this one, #43 |
|
@kinow @MarkEWaite Thanks for the review and guidance on this PR. I really appreciate the feedback and the opportunity to contribute. |
|
Great to hear you will stick around! I'd say look for issues or new features you think are fun or you will learn something. I believe all plugins devs appreciate help. Or look at jenkins core and other libs in Jenkins. There's a lot to have fuj and learn! Cheers |
Fixes JENKINS-43785
Description
This pull request adds the
@Symbol("publishTap")annotation to theTapPublisherdescriptor.With this change, the step can now be used directly in Pipeline scripts as:
Previously, the publisher did not expose a Pipeline symbol, which made its usage in Pipeline jobs less straightforward.
A small Pipeline test has also been added to confirm that the symbol is properly registered and works in a
WorkflowJob.Testing done
mvn clean verifylocally and confirmed all tests pass.TapPublisherPipelineTestto ensure thepublishTapstep works in a Pipeline job.This change does not modify existing behavior, only exposes the publisher through a Pipeline symbol and adds a corresponding test.