download source tap file from build dir#5
Open
forrest79 wants to merge 2 commits intojenkinsci:masterfrom
forrest79:download-source-from-build-dir
Open
download source tap file from build dir#5forrest79 wants to merge 2 commits intojenkinsci:masterfrom forrest79:download-source-from-build-dir
forrest79 wants to merge 2 commits intojenkinsci:masterfrom
forrest79:download-source-from-build-dir
Conversation
… dependency information available)
|
plugins » tap-plugin #55 SUCCESS |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Member
|
Hi @forrest79! We had this behaviour in the past and I removed it in favour of the /view/ URL's because it was possible to access other files via the contents URL (my fault for adding this security bug, of course). I'll give a shot to your pull request in the next days and will merge it after that. I think the build.getRootDir and FilePath together will do the trick. Thanks! |
|
👍 I want this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modified TAP Extended Test Results, source tap file, that can be viewed from this page is loaded from workspace, where is always newest file. According to me, what user want, is file from build, where user is. This modification download source tap file from build directory.
Maybe it could be done in simpliest way :-) Unfortunately I am not an expert on Jenkins plugins :-)