Skip to content

[JENKINS-70869] More efficient JarURLConnection implementation #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

[JENKINS-70869] More efficient JarURLConnection implementation #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsGroovyShell.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@
import java.util.logging.Logger;
import edu.umd.cs.findbugs.annotations.CheckForNull;
import edu.umd.cs.findbugs.annotations.NonNull;
import java.io.File;
import java.io.InputStream;
import java.net.MalformedURLException;
import java.net.URI;
import java.net.URLConnection;
import java.net.URLStreamHandler;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import org.codehaus.groovy.control.CompilationFailedException;
import org.codehaus.groovy.control.CompilationUnit;
import org.codehaus.groovy.control.CompilerConfiguration;
Expand Down Expand Up @@ -76,6 +84,46 @@ private static final class CleanGroovyClassLoader extends GroovyClassLoader {
return new CleanClassCollector(unit, su);
}

private static final Pattern JAR_URL = Pattern.compile("jar:(file:/.+[.]jar)!/.+");

// Avoid expensive and (JDK-6956385) leaky implementations of certain JarURLConnection methods:
@Override public URL findResource(String name) {
URL url = super.findResource(name);
if (url != null && url.getProtocol().equals("jar")) {
try {
return new URL(url.getProtocol(), url.getHost(), url.getPort(), url.getFile(), new URLStreamHandler() {
@Override protected URLConnection openConnection(URL url2) throws IOException {
URLConnection delegate = url.openConnection();
return new URLConnection(url2) {
@Override public void connect() throws IOException {
delegate.connect();
}
@Override public InputStream getInputStream() throws IOException {
return delegate.getInputStream();
}
@Override public String getHeaderField(String name) {
return delegate.getHeaderField(name);
}
@Override public long getLastModified() {
Matcher m = JAR_URL.matcher(url.toString());
if (m.matches()) {
return new File(URI.create(m.group(1))).lastModified();
}
return delegate.getLastModified();
}
@Override public String getContentEncoding() {
return null;
}
};
}
});
} catch (MalformedURLException x) {
LOGGER.log(Level.WARNING, null, x);
}
}
return url;
}

private final class CleanClassCollector extends ClassCollector {

CleanClassCollector(CompilationUnit unit, SourceUnit su) {
Expand Down