Skip to content

Fixed python3.14 type annotation issue#202

Merged
speleo3 merged 2 commits intojensengroup:masterfrom
MattBurn:master
Feb 16, 2026
Merged

Fixed python3.14 type annotation issue#202
speleo3 merged 2 commits intojensengroup:masterfrom
MattBurn:master

Conversation

@MattBurn
Copy link
Contributor

@MattBurn MattBurn commented Feb 2, 2026

Apologies for the delayed response and sorry I didn't notice the file reformatting. I have updated my branch to be in sync with master and added the single line change.

Fixes issue #198

Copy link
Collaborator

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Optional: Could you update the README and the installation.rst to change the minimum python version to 3.10 (instead of 3.8 – probably should have been done in PR #200)?

@orbeckst orbeckst linked an issue Feb 2, 2026 that may be closed by this pull request
@stefdoerr
Copy link
Contributor

stefdoerr commented Feb 6, 2026

Great! I really needed this fix as well. Although I'm not sure if it's maybe better to use inspect.get_annotations() or even better typing.get_type_hints(obj) instead which might be more future proof. Python 3.14 apparently lazily evaluates the annotations so it's better to not access the __annotations__ attribute.

@speleo3
Copy link
Collaborator

speleo3 commented Feb 16, 2026

I'll merge this for now.

Follow-up TODOs:

@speleo3 speleo3 merged commit a8de9a7 into jensengroup:master Feb 16, 2026
11 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Propka is broken for python 3.14

4 participants