Skip to content

Removed versioneer in favor of setuptools-scm#208

Open
stefdoerr wants to merge 10 commits intojensengroup:masterfrom
stefdoerr:setuptools-scm
Open

Removed versioneer in favor of setuptools-scm#208
stefdoerr wants to merge 10 commits intojensengroup:masterfrom
stefdoerr:setuptools-scm

Conversation

@stefdoerr
Copy link
Contributor

@stefdoerr stefdoerr commented Feb 16, 2026

This builds on #206 to remove versioneer. For the real diff check just these commits 7aeb3b0 and ca1a322

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the versioneer package in favor of setuptools-scm for version management, modernizing the Python packaging setup by completing the migration to pyproject.toml started in PR #206.

Changes:

  • Removed versioneer vendored code (versioneer.py, propka/_version.py) and replaced with setuptools-scm integration
  • Deleted setup.py and setup.cfg in favor of pyproject.toml for all packaging configuration
  • Updated version detection in propka/init.py to use importlib.metadata
  • Created LONG_DESCRIPTION.md to separate long description from pyproject.toml
  • Updated MANIFEST.in to reflect new file structure

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
versioneer.py Deleted 2277-line versioneer vendored code file
setup.py Deleted legacy setup.py in favor of pyproject.toml
setup.cfg Deleted legacy configuration file, migrated settings to pyproject.toml
propka/_version.py Deleted versioneer-generated version file
.gitattributes Removed versioneer git export-subst configuration
pyproject.toml Added complete modern packaging configuration with setuptools-scm
propka/init.py Updated version detection to use importlib.metadata
MANIFEST.in Updated to reference new files and exclude old ones
LONG_DESCRIPTION.md Created new file with package description for PyPI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

]
dynamic = ["version"]
dependencies = ["numpy"]
dependencies = []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed numpy as a dep since it's not used in propka. Not sure why it was here, if you think it should stay let me know

@stefdoerr
Copy link
Contributor Author

stefdoerr commented Feb 25, 2026

ok this should be all. I fixed some deprecation warnings of setuptools with regards to the license classifiers which were used.

 * Building wheel...

/tmp/build-env-_ud7imn5/lib/python3.12/site-packages/setuptools/config/_apply_pyprojecttoml.py:82: SetuptoolsDeprecationWarning: `project.license` as a TOML table is deprecated 

and then

 setuptools.errors.InvalidConfigError: License classifiers have been superseded by license expressions (see https://peps.python.org/pep-0639/). Please remove:


License :: OSI Approved :: GNU Lesser General Public License v2 (LGPLv2)


ERROR Backend subprocess exited when trying to invoke get_requires_for_build_sdist 

Copy link
Collaborator

@speleo3 speleo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sobolevnrm
Copy link
Collaborator

Looks good to me as well -- do you want to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants