feat(ci): add the ruff tool to the pre-commit checks#593
Draft
jenstroeger wants to merge 1 commit intostagingfrom
Draft
feat(ci): add the ruff tool to the pre-commit checks#593jenstroeger wants to merge 1 commit intostagingfrom
jenstroeger wants to merge 1 commit intostagingfrom
Conversation
fcda704 to
3a52f2b
Compare
Collaborator
|
What are the additional checks that |
|
ruff could replace almost all the python linters for now, only thing that it can not do for the moment as per my experience, is the typing check, so we could combine ruff with mypy or pyright. |
Owner
Author
|
I agree @copdips, and thank you for the comment! The list of rules that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have talked about
ruffbefore, so this adds an initial setup to play around with. See also #5 (comment).Even though
ruffis supposed to be a drop-in replacement for Flake8 it doesn’t currently support all of the Flake8 plugins we use in this template. I guess for now we therefore keepflake8around. The currentruffconfiguration is derived from the current .flake8 file, but we could consider expanding it.