-
Notifications
You must be signed in to change notification settings - Fork 11
fix(ci): make unique and improve Github workflow job ids to make it easier to reference them from Github settings #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ permissions: | |
| contents: read | ||
|
|
||
| jobs: | ||
| rebase: | ||
| rebase-branch: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -11,7 +11,7 @@ permissions: | |||||
| contents: read | ||||||
|
|
||||||
| jobs: | ||||||
| check: | ||||||
| check-package-for-release: | ||||||
|
||||||
| check-package-for-release: | |
| check-and-build-package: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 2adc4d5.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| needs: [check-package-for-release] | |
| needs: [check-and-build-package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 2adc4d5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 2adc4d5.
Also, should we then rename
_build.yamlto_check_and_build.yaml? The only job in this reusable workflow is also namedcheck-and-build-packageso maybe renaming the workflow file would improve consistency between file name and executed jobs? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current file name is intuitive, and build should only pass when checks pass anyway.