refactor: split mcp_types.ml into 3 sub-modules (949 -> 605 lines)#37
Merged
refactor: split mcp_types.ml into 3 sub-modules (949 -> 605 lines)#37
Conversation
Extract self-contained sections from mcp_types.ml: - mcp_types_completion.ml (83 lines): completion_reference, completion_argument, completion_result, completion_context - mcp_types_elicitation.ml (117 lines): elicitation_schema, elicitation_params, elicitation_action, elicitation_result - mcp_types_tasks.ml (150 lines): task_status, task, task_params, create_task_result, task_execution_support All three sections have zero cross-dependencies with core types. Backward compatibility maintained via include re-exports in mcp_types.ml — all types remain accessible as Mcp_types.*. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_types.ml949줄에서 독립적인 3개 섹션을 별도 모듈로 추출mcp_types_completion.ml(83줄): Completion 타입mcp_types_elicitation.ml(117줄): Elicitation 타입mcp_types_tasks.ml(150줄): Tasks 타입 (experimental)includere-export로 하위 호환성 유지 —Mcp_types.*접근 동일변경 전/후
Test plan
dune build성공dune runtest전 테스트 통과 (변경 없음)Generated with Claude Code