Update schemas from openfec swagger documentation#22
Open
esonderegger wants to merge 1 commit intojeremyjbowers:masterfrom
Open
Update schemas from openfec swagger documentation#22esonderegger wants to merge 1 commit intojeremyjbowers:masterfrom
esonderegger wants to merge 1 commit intojeremyjbowers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
__init__method for each of the classes in pyopenfec to have the fields that are shown in the "response class" for each data type at https://api.open.fec.gov/developers/.The reason I got started exploring with this was that our reporters prefer the
html_urllinks to thepdf_urllinks for reports and filings.Instead of just adding those fields, I figured I would see what else was different between the models and the what is currently in the swagger documentation.
To test the new fields are indeed present, run:
and verify that the link takes you the 2018 Q1 report for Barbara Comstock.
I suppose there is a chance removing fields that are no longer returned by the API could break some code that expects those attributes to be present. I fear it would be confusing to leave them in, though.