Skip to content

Commit 410b218

Browse files
committed
Remove IDNA options usage on TLD conversion
1 parent f67a685 commit 410b218

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/Manager.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ public function __construct(CacheInterface $cache, HttpClient $http, $ttl = null
9191
* @param int $unicodeIDNAOption
9292
*
9393
* @throws SimpleCacheException
94+
* @throws CouldNotLoadRules
9495
*
9596
* @return Rules
9697
*/
@@ -125,6 +126,9 @@ public function getRules(
125126
* @param string $url the Public Suffix List URL
126127
* @param null|mixed $ttl the cache TTL
127128
*
129+
* @throws SimpleCacheException
130+
* @throws HttpClientException
131+
*
128132
* @return bool
129133
*/
130134
public function refreshRules(string $url = self::PSL_URL, $ttl = null): bool
@@ -146,6 +150,7 @@ public function refreshRules(string $url = self::PSL_URL, $ttl = null): bool
146150
* @param int $unicodeIDNAOption
147151
*
148152
* @throws SimpleCacheException
153+
* @throws CouldNotLoadTLDs
149154
*
150155
* @return TopLevelDomains
151156
*/
@@ -188,21 +193,16 @@ public function getTLDs(
188193
* If a local cache already exists, it will be overwritten.
189194
* Returns true if the refresh was successful.
190195
*
191-
* @param string $url the IANA Root Zone Database URL
192-
* @param null|mixed $ttl the cache TTL
193-
* @param int $asciiIDNAOption
194-
* @param int $unicodeIDNAOption
196+
* @param string $url the IANA Root Zone Database URL
197+
* @param null|mixed $ttl the cache TTL
195198
*
196199
* @throws SimpleCacheException
200+
* @throws HttpClientException
197201
*
198202
* @return bool
199203
*/
200-
public function refreshTLDs(
201-
string $url = self::RZD_URL,
202-
$ttl = null,
203-
int $asciiIDNAOption = IDNA_DEFAULT,
204-
int $unicodeIDNAOption = IDNA_DEFAULT
205-
): bool {
204+
public function refreshTLDs(string $url = self::RZD_URL, $ttl = null): bool
205+
{
206206
static $converter;
207207

208208
$converter = $converter ?? new TLDConverter();

0 commit comments

Comments
 (0)