Fixes unit-test-date-helpers failure on win32 #4654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zherczeg This can be merged directly |
lygstate
force-pushed
the
unit-win32-fix
branch
from
c3950ef to
b4f5aeb
Compare
LaszloLango
approved these changes
Nov 12, 2024
[ 22/ 76] FAIL (3221226505): build\tests\unittests-es5.1-math\tests\MinSizeRel\unit-test-date-helpers.exe ================================================ TEST: Assertion 'ecma_date_make_day (1970, -1, 1) == -2678400000' failed at (main)D:\a\jerryscript\jerryscript\tests\unit-core\test-date-helpers.c:110. JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]
LaszloLango
force-pushed
the
unit-win32-fix
branch
from
b4f5aeb to
21639c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ 22/ 76] FAIL (3221226505): build\tests\unittests-es5.1-math\tests\MinSizeRel\unit-test-date-helpers.exe
TEST: Assertion 'ecma_date_make_day (1970, -1, 1) == -2678400000' failed at (main)D:\a\jerryscript\jerryscript\tests\unit-core\test-date-helpers.c:110.
JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]