Skip to content

Conversation

lygstate
Copy link
Contributor

The handler prototype did not match it's implementation

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

@LaszloLango
Copy link
Contributor

Could you please update these two places as well?

jerry-ext/util/print.c:193:} /* jerryx_handler_assert_fatal */ -> jerryx_print_backtrace
jerry-ext/util/handlers.c:96:} /* jerryx_handler_assert_fatal */ -> jerryx_handler_assert

@lygstate
Copy link
Contributor Author

Could you please update these two places as well?

jerry-ext/util/print.c:193:} /* jerryx_handler_assert_fatal */ -> jerryx_print_backtrace jerry-ext/util/handlers.c:96:} /* jerryx_handler_assert_fatal */ -> jerryx_handler_assert

Indeed, I've updated locally, seems it's get lost :(

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The handler prototype did not match it's implementation

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]
@LaszloLango LaszloLango merged commit 82ca949 into jerryscript-project:master Nov 20, 2024
26 checks passed
@lygstate lygstate deleted the sync_api_document branch November 20, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants