Skip to content

Conversation

gergocs
Copy link
Contributor

@gergocs gergocs commented Nov 14, 2024

The work is based on PR #4843, only fixed some conflicts and cppcheck errors.

Co-authored-by: Robert Fancsik [email protected]
Signed-off-by: Gergo Csizi [email protected]

@gergocs gergocs force-pushed the optionalChainingFix branch 4 times, most recently from 532e122 to ec873d7 Compare November 15, 2024 08:50
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little bit worrying about the performance impact of this change. It would nice if we can make sure there is no regression in performance after this change.

@gergocs gergocs force-pushed the optionalChainingFix branch from ec873d7 to c65020b Compare November 19, 2024 11:37
The work is based on PR jerryscript-project#4843, only fixed some conflicts and cppcheck errors.

Co-authored-by: Robert Fancsik [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
@gergocs gergocs force-pushed the optionalChainingFix branch from c65020b to 623f305 Compare November 19, 2024 12:14
@gergocs gergocs requested a review from LaszloLango November 19, 2024 13:54
@LaszloLango LaszloLango added this to the Release 3.0.0 milestone Nov 19, 2024
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit f54f2d3 into jerryscript-project:master Nov 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants