Skip to content

Conversation

gergocs
Copy link
Contributor

@gergocs gergocs commented Nov 15, 2024

The following methods were implemented:
Atomics.compareExchange
Atomics.store

The implementation is based on PR #4956, only resolved the conflicts.

Co-authored-by: Csaba Repasi [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]

Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add more details into the commit message, what operations are implemented and what are still missing?

@ossy-szeged
Copy link
Contributor

ossy-szeged commented Nov 21, 2024

Please add proper ifdef guards not to break non bigint build. See #5047 for details.

Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice patch!

The following methods were implemented:
Atomics.compareExchange
Atomics.store

The implementation is based on PR jerryscript-project#4956, only resolved the conflicts.

Co-authored-by: Csaba Repasi [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaszloLango LaszloLango merged commit 7db6a9a into jerryscript-project:master Nov 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants