-
Notifications
You must be signed in to change notification settings - Fork 683
Implement operations of atomics #5166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add more details into the commit message, what operations are implemented and what are still missing?
Please add proper ifdef guards not to break non bigint build. See #5047 for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice patch!
The following methods were implemented: Atomics.compareExchange Atomics.store The implementation is based on PR jerryscript-project#4956, only resolved the conflicts. Co-authored-by: Csaba Repasi [email protected] JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following methods were implemented:
Atomics.compareExchange
Atomics.store
The implementation is based on PR #4956, only resolved the conflicts.
Co-authored-by: Csaba Repasi [email protected]
JerryScript-DCO-1.0-Signed-off-by: Gergo Csizi [email protected]