Skip to content

Fix database name display in rails 7 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix database name display in rails 7 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f79507b
bundle update
PikachuEXE Oct 17, 2022
7c4f247
Test again rails 6.1
PikachuEXE Oct 17, 2022
5aae7f1
Test against rails 7.0
PikachuEXE Oct 17, 2022
6fec777
Fix issue with rails 7 when fetching database name
PikachuEXE Oct 17, 2022
58b6cf1
Fix CI
PikachuEXE Oct 17, 2022
41980c0
Fix gemfile.lock files
PikachuEXE Oct 17, 2022
78d4c3e
Fix CI by removing failure combination & fixing copy & paste mistake
PikachuEXE Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 34 additions & 12 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,41 @@ on:
jobs:
unit_tests:
name: Unit Tests
if: "contains(github.event.commits[0].message, '[ci skip]') == false"
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
os:
- ubuntu-latest
ruby:
- "2.7"
gemfile:
- gemfiles/rails_5_1.gemfile
- gemfiles/rails_6_0.gemfile
- gemfiles/rails_6_1.gemfile
- gemfiles/rails_7_0.gemfile
allow_failures:
- false
include:
- os: ubuntu-latest
ruby: "3.0"
gemfile: gemfiles/rails_7_0.gemfile
allow_failures: false
- os: ubuntu-latest
ruby: "3.1"
gemfile: gemfiles/rails_7_0.gemfile
allow_failures: false
env:
BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
ALLOW_FAILURES: "${{ matrix.allow_failures }}"
runs-on: ${{ matrix.os }}
continue-on-error: ${{ endsWith(matrix.ruby, 'head') || matrix.ruby == 'debug' }}
steps:
- name: Checkout
uses: actions/checkout@v2
# - name: Setup Ruby
# uses: ruby/setup-ruby@v1
# with:
# ruby-version: ${{ matrix.ruby }}
# bundler-cache: true
uses: actions/checkout@v3
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Test
run: |
bundle install
bundle exec appraisal install
bundle exec appraisal rspec
run: bundle exec rake spec || $ALLOW_FAILURES
5 changes: 2 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@
# rspec failure tracking
.rspec_status

spec/support/rails_app_5_1_5/db/
spec/support/rails_app_5_2_4_3/db/
TODO.md
spec/support/rails_app_*/db/
TODO.md
22 changes: 14 additions & 8 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
appraise "rails_5_1_5" do
gem "rails", "5.1.5"
appraise "rails_5_1" do
gem "rails", "~> 5.1.0"
gem 'sqlite3', '~> 1.3.6'
end

appraise "rails_5_2_4_3" do
gem "rails", "5.2.4.3"
gem 'sqlite3', '~> 1.4.2'
appraise "rails_5_2" do
gem "rails", "~> 5.2.0"
end

appraise "rails_6_0_3_4" do
gem "rails", "6.0.3.4"
gem 'sqlite3', '~> 1.4.2'
appraise "rails_6_0" do
gem "rails", "~> 6.0.0"
end

appraise "rails_6_1" do
gem "rails", "~> 6.1.0"
end

appraise "rails_7_0" do
gem "rails", "~> 7.0.0"
end
207 changes: 101 additions & 106 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,91 +8,90 @@ PATH
GEM
remote: https://rubygems.org/
specs:
actioncable (6.0.3.4)
actionpack (= 6.0.3.4)
actioncable (6.0.6)
actionpack (= 6.0.6)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
actionmailbox (6.0.3.4)
actionpack (= 6.0.3.4)
activejob (= 6.0.3.4)
activerecord (= 6.0.3.4)
activestorage (= 6.0.3.4)
activesupport (= 6.0.3.4)
actionmailbox (6.0.6)
actionpack (= 6.0.6)
activejob (= 6.0.6)
activerecord (= 6.0.6)
activestorage (= 6.0.6)
activesupport (= 6.0.6)
mail (>= 2.7.1)
actionmailer (6.0.3.4)
actionpack (= 6.0.3.4)
actionview (= 6.0.3.4)
activejob (= 6.0.3.4)
actionmailer (6.0.6)
actionpack (= 6.0.6)
actionview (= 6.0.6)
activejob (= 6.0.6)
mail (~> 2.5, >= 2.5.4)
rails-dom-testing (~> 2.0)
actionpack (6.0.3.4)
actionview (= 6.0.3.4)
activesupport (= 6.0.3.4)
actionpack (6.0.6)
actionview (= 6.0.6)
activesupport (= 6.0.6)
rack (~> 2.0, >= 2.0.8)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.0, >= 1.2.0)
actiontext (6.0.3.4)
actionpack (= 6.0.3.4)
activerecord (= 6.0.3.4)
activestorage (= 6.0.3.4)
activesupport (= 6.0.3.4)
actiontext (6.0.6)
actionpack (= 6.0.6)
activerecord (= 6.0.6)
activestorage (= 6.0.6)
activesupport (= 6.0.6)
nokogiri (>= 1.8.5)
actionview (6.0.3.4)
activesupport (= 6.0.3.4)
actionview (6.0.6)
activesupport (= 6.0.6)
builder (~> 3.1)
erubi (~> 1.4)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.1, >= 1.2.0)
activejob (6.0.3.4)
activesupport (= 6.0.3.4)
activejob (6.0.6)
activesupport (= 6.0.6)
globalid (>= 0.3.6)
activemodel (6.0.3.4)
activesupport (= 6.0.3.4)
activerecord (6.0.3.4)
activemodel (= 6.0.3.4)
activesupport (= 6.0.3.4)
activestorage (6.0.3.4)
actionpack (= 6.0.3.4)
activejob (= 6.0.3.4)
activerecord (= 6.0.3.4)
marcel (~> 0.3.1)
activesupport (6.0.3.4)
activemodel (6.0.6)
activesupport (= 6.0.6)
activerecord (6.0.6)
activemodel (= 6.0.6)
activesupport (= 6.0.6)
activestorage (6.0.6)
actionpack (= 6.0.6)
activejob (= 6.0.6)
activerecord (= 6.0.6)
marcel (~> 1.0)
activesupport (6.0.6)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
appraisal (2.3.0)
appraisal (2.4.1)
bundler
rake
thor (>= 0.14.0)
builder (3.2.4)
byebug (11.1.3)
coderay (1.1.3)
concurrent-ruby (1.1.7)
concurrent-ruby (1.1.10)
crass (1.0.6)
diff-lcs (1.4.4)
erubi (1.9.0)
globalid (0.4.2)
activesupport (>= 4.2.0)
i18n (1.8.5)
diff-lcs (1.5.0)
erubi (1.11.0)
globalid (1.0.0)
activesupport (>= 5.0)
i18n (1.12.0)
concurrent-ruby (~> 1.0)
loofah (2.7.0)
loofah (2.19.0)
crass (~> 1.0.2)
nokogiri (>= 1.5.9)
mail (2.7.1)
mini_mime (>= 0.1.1)
marcel (0.3.3)
mimemagic (~> 0.3.2)
marcel (1.0.2)
method_source (1.0.0)
mimemagic (0.3.5)
mini_mime (1.0.2)
mini_portile2 (2.4.0)
minitest (5.14.2)
nio4r (2.5.4)
nokogiri (1.10.10)
mini_portile2 (~> 2.4.0)
mini_mime (1.1.2)
minitest (5.16.3)
nio4r (2.5.8)
nokogiri (1.13.8-arm64-darwin)
racc (~> 1.4)
nokogiri (1.13.8-x86_64-linux)
racc (~> 1.4)
pastel (0.8.0)
tty-color (~> 0.5)
pry (0.13.1)
Expand All @@ -101,69 +100,64 @@ GEM
pry-byebug (3.9.0)
byebug (~> 11.0)
pry (~> 0.13.0)
rack (2.2.3)
rack-test (1.1.0)
rack (>= 1.0, < 3)
rails (6.0.3.4)
actioncable (= 6.0.3.4)
actionmailbox (= 6.0.3.4)
actionmailer (= 6.0.3.4)
actionpack (= 6.0.3.4)
actiontext (= 6.0.3.4)
actionview (= 6.0.3.4)
activejob (= 6.0.3.4)
activemodel (= 6.0.3.4)
activerecord (= 6.0.3.4)
activestorage (= 6.0.3.4)
activesupport (= 6.0.3.4)
racc (1.6.0)
rack (2.2.4)
rack-test (2.0.2)
rack (>= 1.3)
rails (6.0.6)
actioncable (= 6.0.6)
actionmailbox (= 6.0.6)
actionmailer (= 6.0.6)
actionpack (= 6.0.6)
actiontext (= 6.0.6)
actionview (= 6.0.6)
activejob (= 6.0.6)
activemodel (= 6.0.6)
activerecord (= 6.0.6)
activestorage (= 6.0.6)
activesupport (= 6.0.6)
bundler (>= 1.3.0)
railties (= 6.0.3.4)
railties (= 6.0.6)
sprockets-rails (>= 2.0.0)
rails-dom-testing (2.0.3)
activesupport (>= 4.2.0)
nokogiri (>= 1.6)
rails-html-sanitizer (1.3.0)
rails-html-sanitizer (1.4.3)
loofah (~> 2.3)
railties (6.0.3.4)
actionpack (= 6.0.3.4)
activesupport (= 6.0.3.4)
railties (6.0.6)
actionpack (= 6.0.6)
activesupport (= 6.0.6)
method_source
rake (>= 0.8.7)
thor (>= 0.20.3, < 2.0)
rake (13.0.1)
rspec (3.9.0)
rspec-core (~> 3.9.0)
rspec-expectations (~> 3.9.0)
rspec-mocks (~> 3.9.0)
rspec-core (3.9.3)
rspec-support (~> 3.9.3)
rspec-expectations (3.9.2)
rake (13.0.6)
rspec (3.11.0)
rspec-core (~> 3.11.0)
rspec-expectations (~> 3.11.0)
rspec-mocks (~> 3.11.0)
rspec-core (3.11.0)
rspec-support (~> 3.11.0)
rspec-expectations (3.11.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.9.0)
rspec-mocks (3.9.1)
rspec-support (~> 3.11.0)
rspec-mocks (3.11.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.9.0)
rspec-support (3.9.3)
sorbet (0.5.6303)
sorbet-static (= 0.5.6303)
sorbet-runtime (0.5.6303)
sorbet-static (0.5.6303-universal-darwin-14)
sorbet-static (0.5.6303-universal-darwin-15)
sorbet-static (0.5.6303-universal-darwin-16)
sorbet-static (0.5.6303-universal-darwin-17)
sorbet-static (0.5.6303-universal-darwin-18)
sorbet-static (0.5.6303-universal-darwin-19)
sorbet-static (0.5.6303-universal-darwin-20)
sorbet-static (0.5.6303-x86_64-linux)
sprockets (4.0.2)
rspec-support (~> 3.11.0)
rspec-support (3.11.1)
sorbet (0.5.10488)
sorbet-static (= 0.5.10488)
sorbet-runtime (0.5.10488)
sorbet-static (0.5.10488-universal-darwin-21)
sorbet-static (0.5.10488-x86_64-linux)
sprockets (4.1.1)
concurrent-ruby (~> 1.0)
rack (> 1, < 3)
sprockets-rails (3.2.2)
actionpack (>= 4.0)
activesupport (>= 4.0)
sprockets-rails (3.4.2)
actionpack (>= 5.2)
activesupport (>= 5.2)
sprockets (>= 3.0.0)
sqlite3 (1.4.2)
thor (1.0.1)
sqlite3 (1.4.4)
thor (1.2.1)
thread_safe (0.3.6)
tty-color (0.6.0)
tty-cursor (0.7.1)
Expand All @@ -175,16 +169,17 @@ GEM
tty-screen (~> 0.8)
wisper (~> 2.0)
tty-screen (0.8.1)
tzinfo (1.2.7)
tzinfo (1.2.10)
thread_safe (~> 0.1)
websocket-driver (0.7.3)
websocket-driver (0.7.5)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.5)
wisper (2.0.1)
zeitwerk (2.4.0)
zeitwerk (2.6.1)

PLATFORMS
ruby
arm64-darwin-21
x86_64-linux

DEPENDENCIES
appraisal
Expand All @@ -198,4 +193,4 @@ DEPENDENCIES
sqlite3 (~> 1.4.2)

BUNDLED WITH
2.2.3
2.3.23
2 changes: 1 addition & 1 deletion gemfiles/rails_5_1_5.gemfile → gemfiles/rails_5_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source "https://rubygems.org"

gem "rails", "5.1.5"
gem "rails", "~> 5.1.0"
gem "sqlite3", "~> 1.3.6"

gemspec path: "../"
Loading