Conversation
|
It seems that I was missing the code of the PR #511 that was merged early June. The code of this branch is a bit cleaner and now works for me |
|
I'll get to the tests in a few days. |
pkg/commands/docker.go
Outdated
| client.FromEnv, | ||
| client.WithVersion(APIVersion), | ||
| } | ||
| // For an ssh connection the DOCKER_HOST env variable has been overridden. |
There was a problem hiding this comment.
Could you explain the rationale behind these changes? I'm not clear on the reasoning
There was a problem hiding this comment.
I just wired it correctly for the SSH connection to work.
I'll rework it so its clearer and doesn't rely on a modified docker host env variable.
There was a problem hiding this comment.
Hey @jesseduffield took over 6 months to get some free time but now that I'm in vacation... :D
The rationale is that ATM ssh tunneling with docker context over lazydocker is broken. There are a few issues regarding this see this link
In my opinion those issues are due to an edge case in the current implementation of the ssh tunneling & docker host parsing.
I've rewritten a few parts to both make it simpler and more robust, tell me what you think :)
…est of the structure
|
Anyway this get's merged soon @jesseduffield? I'd love to have it. |
Maintenance/bump ci cd dependencies
|
What's the latest here? |
|
@wpcarro waiting for merge on this repo. Works on my fork. |
|
Sorry haven't tried this. I'm on a work break and not sure I'll have a
chance to look at it until next week. BTW...my use case is from WSL.
…On Fri, Nov 21, 2025, 6:16 PM PÉAU Clément ***@***.***> wrote:
*peauc* left a comment (jesseduffield/lazydocker#577)
<#577 (comment)>
@wpcarro <https://github.com/wpcarro> waiting for merge on this repo.
Works on my fork.
—
Reply to this email directly, view it on GitHub
<#577 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALAW2DFQPDC5JKT4Z3ORLD356TNNAVCNFSM6AAAAABNQ3LW7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKNRVGA3DSOBWGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
If anyone is interested in this thread. I've released |
4 participants
Fix issue as described in #559