Add clipboard support & feature to copy container id#584
Open
peauc wants to merge 3 commits intojesseduffield:masterfrom
Open
Add clipboard support & feature to copy container id#584peauc wants to merge 3 commits intojesseduffield:masterfrom
peauc wants to merge 3 commits intojesseduffield:masterfrom
Conversation
peauc
force-pushed
the
feature/add_clipboard_support
branch
from
6e8bbcc to
5846bd3
Compare
Owner
jesseduffield
left a comment
jesseduffield
left a comment
There was a problem hiding this comment.
Sorry for late review: I'm going to try and chip away at this stuff over time. Couple comments
pkg/gui/app_status_manager.go
Outdated
Owner
There was a problem hiding this comment.
Given that removeStatus tries to obtain the lock that addWaitingStatus already holds, wouldn't that cause a deadlock?
Contributor
Author
There was a problem hiding this comment.
There might be issues with my understanding of the locks. I'll double/triple check 👍
pkg/gui/containers_panel.go
Outdated
Owner
There was a problem hiding this comment.
This isn't really a waiting status: it's a toast message. We should update the naming to reflect that (and I haven't tested it locally but it's important we don't show a loading spinner on this)
Contributor
Author
There was a problem hiding this comment.
yes thanks for the feedback. I'll go over it again. 👍
peauc
force-pushed
the
feature/add_clipboard_support
branch
2 times, most recently
from
1bf911e to
82912be
Compare
peauc
force-pushed
the
feature/add_clipboard_support
branch
from
82912be to
70e96c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #580