Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 136 additions & 0 deletions pkg/commands/patch/patch_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,142 @@ func TestAdjustLineNumber(t *testing.T) {
}
}

func TestTransformNonContiguousSelection(t *testing.T) {
const changeBlockDiff = `diff --git a/test.c b/test.c
index 1234567..abcdefg 100644
--- a/test.c
+++ b/test.c
@@ -1,6 +1,6 @@
int main() {
- // init something
- int i = 0;
+ // init variables
+ int x = 0;

return 0;
}
`

scenarios := []struct {
testName string
selectedIndices []int
reverse bool
expected string
}{
{
testName: "non-contiguous selection keeps change pairs together",
selectedIndices: []int{6, 8},
reverse: false,
expected: `--- a/test.c
+++ b/test.c
@@ -1,6 +1,6 @@
int main() {
- // init something
+ // init variables
int i = 0;

return 0;
}
`,
},
{
testName: "select only deletions without additions",
selectedIndices: []int{6, 7},
reverse: false,
expected: `--- a/test.c
+++ b/test.c
@@ -1,6 +1,4 @@
int main() {
- // init something
- int i = 0;

return 0;
}
`,
},
{
testName: "select only additions without deletions",
selectedIndices: []int{8, 9},
reverse: false,
expected: `--- a/test.c
+++ b/test.c
@@ -1,6 +1,8 @@
int main() {
// init something
int i = 0;
+ // init variables
+ int x = 0;

return 0;
}
`,
},
{
testName: "select all lines in change block",
selectedIndices: []int{6, 7, 8, 9},
reverse: false,
expected: `--- a/test.c
+++ b/test.c
@@ -1,6 +1,6 @@
int main() {
- // init something
- int i = 0;
+ // init variables
+ int x = 0;

return 0;
}
`,
},
{
testName: "select second deletion and second addition",
selectedIndices: []int{7, 9},
reverse: false,
expected: `--- a/test.c
+++ b/test.c
@@ -1,6 +1,6 @@
int main() {
// init something
- int i = 0;
+ int x = 0;

return 0;
}
`,
},
{
testName: "reverse mode - non-contiguous selection",
selectedIndices: []int{6, 8},
reverse: true,
expected: `--- a/test.c
+++ b/test.c
@@ -1,6 +1,6 @@
int main() {
- // init something
+ // init variables
int x = 0;

return 0;
}
`,
},
}

for _, s := range scenarios {
t.Run(s.testName, func(t *testing.T) {
result := Parse(changeBlockDiff).
Transform(TransformOpts{
Reverse: s.reverse,
FileNameOverride: "test.c",
IncludedLineIndices: s.selectedIndices,
}).
FormatPlain()

assert.Equal(t, s.expected, result)
})
}
}

func TestIsSingleHunkForWholeFile(t *testing.T) {
scenarios := []struct {
testName string
Expand Down
67 changes: 66 additions & 1 deletion pkg/commands/patch/transform.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,78 @@ func (self *patchTransformer) transformHunkLines(hunk *Hunk, firstLineIdx int) [
skippedNewlineMessageIndex := -1
newLines := []*PatchLine{}

for i, line := range hunk.bodyLines {
for i := 0; i < len(hunk.bodyLines); i++ {
line := hunk.bodyLines[i]
lineIdx := i + firstLineIdx + 1 // plus one for header line
if line.Content == "" {
break
}
isLineSelected := lo.Contains(self.opts.IncludedLineIndices, lineIdx)

// Handle change block (multiple consecutive deletions followed by additions)
if line.Kind == DELETION {
deletionCount := 0
for j := i; j < len(hunk.bodyLines) && hunk.bodyLines[j].Kind == DELETION; j++ {
deletionCount++
}
if deletionCount > 1 {
selectedDeletions := []*PatchLine{}
leadingContext := []*PatchLine{}
trailingContext := []*PatchLine{}
foundFirstSelectedDeletion := false

for j := 0; j < deletionCount; j++ {
delLine := hunk.bodyLines[i+j]
delLineIdx := i + j + firstLineIdx + 1
if lo.Contains(self.opts.IncludedLineIndices, delLineIdx) {
foundFirstSelectedDeletion = true
selectedDeletions = append(selectedDeletions, delLine)
} else if !self.opts.Reverse {
ctx := &PatchLine{Kind: CONTEXT, Content: " " + delLine.Content[1:]}
if foundFirstSelectedDeletion {
trailingContext = append(trailingContext, ctx)
} else {
leadingContext = append(leadingContext, ctx)
}
}
}

// Process additions in the block
selectedAdditions := []*PatchLine{}
trailingAdditionContext := []*PatchLine{}
foundFirstSelectedAddition := false
addIdx := i + deletionCount
for addIdx < len(hunk.bodyLines) && hunk.bodyLines[addIdx].Kind == ADDITION {
addLine := hunk.bodyLines[addIdx]
addLineIdx := addIdx + firstLineIdx + 1
if lo.Contains(self.opts.IncludedLineIndices, addLineIdx) {
foundFirstSelectedAddition = true
selectedAdditions = append(selectedAdditions, addLine)
} else if self.opts.Reverse {
ctx := &PatchLine{Kind: CONTEXT, Content: " " + addLine.Content[1:]}
if foundFirstSelectedAddition {
trailingAdditionContext = append(trailingAdditionContext, ctx)
}
// In reverse mode, unselected additions before any selected addition are dropped.
// Unselected additions after a selected addition become context.
} else {
skippedNewlineMessageIndex = addLineIdx + 1
}
addIdx++
}

// Output order: leading context, deletions, additions, trailing context, trailing addition context
newLines = append(newLines, leadingContext...)
newLines = append(newLines, selectedDeletions...)
newLines = append(newLines, selectedAdditions...)
newLines = append(newLines, trailingContext...)
newLines = append(newLines, trailingAdditionContext...)

i = addIdx - 1
continue
}
}

if isLineSelected || (line.Kind == NEWLINE_MESSAGE && skippedNewlineMessageIndex != lineIdx) || line.Kind == CONTEXT {
newLines = append(newLines, line)
continue
Expand Down