Skip to content

Conversation

FloEdelmann
Copy link
Contributor

Fixes #1678.

@G-Rath
Copy link
Collaborator

G-Rath commented Dec 3, 2024

While technically a fix, changing configs is usually considered a breaking change for eslint plugins and we're expecting to do a new major "soon" so I don't think we can land this for now

@FloEdelmann
Copy link
Contributor Author

FloEdelmann commented Dec 3, 2024

changing configs is usually considered a breaking change

Even removing rules from configs? It will technically result in less lint errors, so that shouldn't be breaking. But well, most people probably extend recommended+style, so that does increase the rule severity from warn to error, so it might indeed break some builds.

I'll change the commit message to include a ! (to indicate the breaking change) and we can just leave this PR open until you're comfortable with merging it.

@FloEdelmann FloEdelmann changed the title fix: remove no-alias-methods from style config fix!: remove no-alias-methods from style config Dec 3, 2024
@G-Rath
Copy link
Collaborator

G-Rath commented Jun 18, 2025

This has been addressed in v29 which was just released - I had intended to attribute the commit to you but the release got mucked up so sorry about that

@G-Rath G-Rath closed this Jun 18, 2025
@FloEdelmann FloEdelmann deleted the no-alias-methods branch June 18, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

no-alias-methods error in recommended, warn in style

2 participants