Skip to content

Conversation

sonnyp
Copy link
Contributor

@sonnyp sonnyp commented Dec 20, 2024

@sonnyp sonnyp force-pushed the valid-expect-minArgs-0 branch from 3a7fed7 to 53f6330 Compare December 20, 2024 19:56
@sonnyp sonnyp changed the title feat: Allow minArgs 0 for valid-expect feat: allow minArgs 0 for valid-expect Dec 20, 2024
@G-Rath
Copy link
Collaborator

G-Rath commented Dec 20, 2024

thanks, I'm happy with this but will probably wait until after the holidays to land this to give the link checker a chance to come right (seems to be unhappy with https://eslint.org/docs/latest/use/core-concepts#rule-suggestions which looks bonked anyway, and is generated by eslint-doc-generator so I'm hopeful it'll get resolved upstream)

@G-Rath G-Rath force-pushed the valid-expect-minArgs-0 branch from 53f6330 to d361eee Compare January 13, 2025 19:13
@G-Rath G-Rath changed the title feat: allow minArgs 0 for valid-expect feat(valid-expect): allow calling expect with no arguments Jan 15, 2025
@G-Rath G-Rath merged commit ff0349e into jest-community:main Jan 15, 2025
53 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
# [28.11.0](v28.10.1...v28.11.0) (2025-01-15)

### Features

* **valid-expect:** allow calling `expect` with no arguments ([#1688](#1688)) ([ff0349e](ff0349e))
Copy link

🎉 This PR is included in version 28.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sonnyp sonnyp deleted the valid-expect-minArgs-0 branch January 15, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants