Skip to content

refactor(prefer-lowercase-title): rename message id #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

refactor(prefer-lowercase-title): rename message id #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions src/rules/__tests__/prefer-lowercase-title.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "it('foo', function () {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 4,
line: 1,
Expand All @@ -89,7 +89,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "xit('foo', function () {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.xit },
column: 5,
line: 1,
Expand All @@ -101,7 +101,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'it("foo", function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 4,
line: 1,
Expand All @@ -113,7 +113,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'it(`foo`, function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 4,
line: 1,
Expand All @@ -125,7 +125,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "test('foo', function () {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.test },
column: 6,
line: 1,
Expand All @@ -137,7 +137,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "xtest('foo', function () {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.xtest },
column: 7,
line: 1,
Expand All @@ -149,7 +149,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'test("foo", function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.test },
column: 6,
line: 1,
Expand All @@ -161,7 +161,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'test(`foo`, function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.test },
column: 6,
line: 1,
Expand All @@ -173,7 +173,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "describe('foo', function () {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
Expand All @@ -185,7 +185,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'describe("foo", function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
Expand All @@ -197,7 +197,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'describe(`foo`, function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
Expand All @@ -218,7 +218,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
parserOptions: { sourceType: 'module' },
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 9,
line: 3,
Expand All @@ -230,7 +230,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'describe(`some longer description`, function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
Expand All @@ -242,7 +242,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: 'fdescribe(`some longer description`, function () {})',
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.fdescribe },
column: 11,
line: 1,
Expand All @@ -254,7 +254,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "it.each(['green', 'black'])('should return %', () => {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 29,
line: 1,
Expand All @@ -266,7 +266,7 @@ ruleTester.run('prefer-lowercase-title', rule, {
output: "describe.each(['green', 'black'])('should return %', () => {})",
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 35,
line: 1,
Expand Down Expand Up @@ -306,7 +306,7 @@ ruleTester.run('prefer-lowercase-title with ignore=describe', rule, {
options: [{ ignore: [DescribeAlias.describe] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.test },
column: 6,
line: 1,
Expand All @@ -319,7 +319,7 @@ ruleTester.run('prefer-lowercase-title with ignore=describe', rule, {
options: [{ ignore: [DescribeAlias.describe] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.xit },
column: 5,
line: 1,
Expand Down Expand Up @@ -359,7 +359,7 @@ ruleTester.run('prefer-lowercase-title with ignore=test', rule, {
options: [{ ignore: [TestCaseName.test] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
Expand All @@ -372,7 +372,7 @@ ruleTester.run('prefer-lowercase-title with ignore=test', rule, {
options: [{ ignore: [TestCaseName.test] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 4,
line: 1,
Expand All @@ -385,7 +385,7 @@ ruleTester.run('prefer-lowercase-title with ignore=test', rule, {
options: [{ ignore: [TestCaseName.test] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.xit },
column: 5,
line: 1,
Expand Down Expand Up @@ -425,7 +425,7 @@ ruleTester.run('prefer-lowercase-title with ignore=it', rule, {
options: [{ ignore: [TestCaseName.it] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
Expand All @@ -438,7 +438,7 @@ ruleTester.run('prefer-lowercase-title with ignore=it', rule, {
options: [{ ignore: [TestCaseName.it] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.test },
column: 6,
line: 1,
Expand All @@ -451,7 +451,7 @@ ruleTester.run('prefer-lowercase-title with ignore=it', rule, {
options: [{ ignore: [TestCaseName.it] }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.xtest },
column: 7,
line: 1,
Expand Down Expand Up @@ -521,7 +521,7 @@ ruleTester.run('prefer-lowercase-title with ignoreTopLevelDescribe', rule, {
options: [{ ignoreTopLevelDescribe: true }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 4,
line: 1,
Expand Down Expand Up @@ -550,13 +550,13 @@ ruleTester.run('prefer-lowercase-title with ignoreTopLevelDescribe', rule, {
options: [{ ignoreTopLevelDescribe: true }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 12,
line: 2,
},
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 8,
line: 3,
Expand Down Expand Up @@ -590,13 +590,13 @@ ruleTester.run('prefer-lowercase-title with ignoreTopLevelDescribe', rule, {
parserOptions: { sourceType: 'module' },
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 11,
line: 4,
},
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 8,
line: 5,
Expand Down Expand Up @@ -625,19 +625,19 @@ ruleTester.run('prefer-lowercase-title with ignoreTopLevelDescribe', rule, {
options: [{ ignoreTopLevelDescribe: false }],
errors: [
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 10,
line: 1,
},
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: DescribeAlias.describe },
column: 12,
line: 2,
},
{
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
data: { method: TestCaseName.it },
column: 8,
line: 3,
Expand Down
6 changes: 3 additions & 3 deletions src/rules/prefer-lowercase-title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export default createRule<
ignoreTopLevelDescribe: boolean;
}>,
],
'unexpectedLowercase'
'unexpectedCase'
>({
name: __filename,
meta: {
Expand All @@ -59,7 +59,7 @@ export default createRule<
},
fixable: 'code',
messages: {
unexpectedLowercase: '`{{ method }}`s should begin with lowercase',
unexpectedCase: '`{{ method }}`s should begin with lowercase',
},
schema: [
{
Expand Down Expand Up @@ -140,7 +140,7 @@ export default createRule<
}

context.report({
messageId: 'unexpectedLowercase',
messageId: 'unexpectedCase',
node: node.arguments[0],
data: { method: jestFnCall.name },
fix(fixer) {
Expand Down