Skip to content

refactor: use declaration merging instead of casting for accessing plugin settings #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025
Merged

refactor: use declaration merging instead of casting for accessing plugin settings #1768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 10 additions & 12 deletions src/rules/utils/parseJestFnCall.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,22 +183,21 @@ const ValidJestFnCallChains = [
'xtest.failing.each',
];

// todo: switch back to using declaration merging once https://github.com/typescript-eslint/typescript-eslint/pull/8485
// is landed
interface SharedConfigurationSettings {
jest?: {
globalAliases?: Record<string, string[]>;
globalPackage?: string;
version?: number | string;
};
declare module '@typescript-eslint/utils/ts-eslint' {
export interface SharedConfigurationSettings {
jest?: {
globalAliases?: Record<string, string[]>;
globalPackage?: string;
version?: number | string;
};
}
}

const resolvePossibleAliasedGlobal = (
global: string,
context: TSESLint.RuleContext<string, unknown[]>,
) => {
const globalAliases =
(context.settings as SharedConfigurationSettings).jest?.globalAliases ?? {};
const globalAliases = context.settings.jest?.globalAliases ?? {};

const alias = Object.entries(globalAliases).find(([, aliases]) =>
aliases.includes(global),
Expand Down Expand Up @@ -589,8 +588,7 @@ const resolveToJestFn = (

if (maybeImport) {
const globalPackage =
(context.settings as SharedConfigurationSettings).jest?.globalPackage ??
'@jest/globals';
context.settings.jest?.globalPackage ?? '@jest/globals';

// the identifier is imported from our global package so return the original import name
if (maybeImport.source === globalPackage) {
Expand Down