feat(vault): HashiCorp Vault + AWS Secrets Manager plugins - #261
Open
LiorFink00 wants to merge 1 commit into
Open
feat(vault): HashiCorp Vault + AWS Secrets Manager plugins#261LiorFink00 wants to merge 1 commit into
LiorFink00 wants to merge 1 commit into
Conversation
Task 4 of the secret-manager honeytoken feature (#255): the two secret-manager plugins, the first pieces that make real external API calls. - plugins/vault/hashicorp: AppRole auth (hvac), KV v2 plant/delete, and read detection by parsing the file audit device's NDJSON log. poll() accepts the connection's last-poll `since` to bound the scan. - plugins/vault/aws: IAM-key auth (boto3), Secrets Manager create/put/delete, and read detection via CloudTrail GetSecretValue lookup (with a 20-min lookback for CloudTrail delivery lag; the poller dedups by event_id). - Adds runtime deps: hvac>=2.0, boto3>=1.34. Stacked on #257 (the VaultPlugin base). Wired into API routes + the poller in the remaining #255 tasks. Ported from the enterprise implementation; poll() is aligned to the VaultPlugin ABC's (paths, since) signature. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018DARDAxeg4NM8FKoyGMQZy
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 4 of #255 (secret-manager honeytokens) — the two secret-manager plugins. Stacked on #257 (base =
feat/vault-plugin-framework), so this diff is just the plugins; it retargets tomainonce #257 lands.Changes
plugins/vault/hashicorp— AppRole auth (hvac), KV v2create_or_update/delete, read detection by parsing the file audit device's NDJSON log.poll(paths, since)seeds its cutoff from the connection's last poll.plugins/vault/aws— IAM-key auth (boto3), Secrets Managercreate/put/delete, read detection via CloudTrailGetSecretValuelookup (20-min lookback for CloudTrail's delivery lag; the poller dedups byevent_id).hvac>=2.0,boto3>=1.34.Note on dependencies
This is the flagged dependency expansion —
hvac(Vault HTTP client) andboto3(AWS SDK). Both are the standard clients for their respective services.Tests
tests/test_hashicorp_plugin.py(ported) — connect/plant/delete/poll with a fakedhvacclient + audit entries.tests/test_aws_vault_plugin.py(new) — connect validation, plant/delete, and CloudTrail→AccessEventparsing with a fakedboto3session.Part of #255.