Skip to content

Conversation

joshkel
Copy link
Contributor

@joshkel joshkel commented Aug 2, 2025

Tests within e2e/__tests__/customReportersOnCircus.test.ts were reporting started: invalid for me, because new Date(Date.now() - testCaseResult.startedAt).getDate() evaluated to 31 (i.e., Dec 31 1969) instead of 1 (Jan 1 1970 midnight UTC).

The intention is apparently to verify that the tests' startedAt is a valid timestamp, so I revised it accordingly.

The tests that I'm modifying were added in #15145.

Tests within e2e/__tests__/customReportersOnCircus.test.ts were reporting `started: invalid` for me, because `new Date(Date.now() - testCaseResult.startedAt).getDate()` evaluated to 31 (i.e., Dec 31 1969) instead of 1 (Jan 1 1970 midnight UTC).

The intention is apparently to verify that the tests' startedAt is a valid timestamp, so I revised it accordingly.
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 12c8a48
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/688e794f4d1ff30008bedaa4
😎 Deploy Preview https://deploy-preview-15768--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

pkg-pr-new bot commented Aug 2, 2025

Open in StackBlitz

babel-jest

npm i https://pkg.pr.new/babel-jest@15768

babel-plugin-jest-hoist

npm i https://pkg.pr.new/babel-plugin-jest-hoist@15768

babel-preset-jest

npm i https://pkg.pr.new/babel-preset-jest@15768

create-jest

npm i https://pkg.pr.new/create-jest@15768

@jest/diff-sequences

npm i https://pkg.pr.new/@jest/diff-sequences@15768

expect

npm i https://pkg.pr.new/expect@15768

@jest/expect-utils

npm i https://pkg.pr.new/@jest/expect-utils@15768

jest

npm i https://pkg.pr.new/jest@15768

jest-changed-files

npm i https://pkg.pr.new/jest-changed-files@15768

jest-circus

npm i https://pkg.pr.new/jest-circus@15768

jest-cli

npm i https://pkg.pr.new/jest-cli@15768

jest-config

npm i https://pkg.pr.new/jest-config@15768

@jest/console

npm i https://pkg.pr.new/@jest/console@15768

@jest/core

npm i https://pkg.pr.new/@jest/core@15768

@jest/create-cache-key-function

npm i https://pkg.pr.new/@jest/create-cache-key-function@15768

jest-diff

npm i https://pkg.pr.new/jest-diff@15768

jest-docblock

npm i https://pkg.pr.new/jest-docblock@15768

jest-each

npm i https://pkg.pr.new/jest-each@15768

@jest/environment

npm i https://pkg.pr.new/@jest/environment@15768

jest-environment-jsdom

npm i https://pkg.pr.new/jest-environment-jsdom@15768

@jest/environment-jsdom-abstract

npm i https://pkg.pr.new/@jest/environment-jsdom-abstract@15768

jest-environment-node

npm i https://pkg.pr.new/jest-environment-node@15768

@jest/expect

npm i https://pkg.pr.new/@jest/expect@15768

@jest/fake-timers

npm i https://pkg.pr.new/@jest/fake-timers@15768

@jest/get-type

npm i https://pkg.pr.new/@jest/get-type@15768

@jest/globals

npm i https://pkg.pr.new/@jest/globals@15768

jest-haste-map

npm i https://pkg.pr.new/jest-haste-map@15768

jest-jasmine2

npm i https://pkg.pr.new/jest-jasmine2@15768

jest-leak-detector

npm i https://pkg.pr.new/jest-leak-detector@15768

jest-matcher-utils

npm i https://pkg.pr.new/jest-matcher-utils@15768

jest-message-util

npm i https://pkg.pr.new/jest-message-util@15768

jest-mock

npm i https://pkg.pr.new/jest-mock@15768

@jest/pattern

npm i https://pkg.pr.new/@jest/pattern@15768

jest-phabricator

npm i https://pkg.pr.new/jest-phabricator@15768

jest-regex-util

npm i https://pkg.pr.new/jest-regex-util@15768

@jest/reporters

npm i https://pkg.pr.new/@jest/reporters@15768

jest-resolve

npm i https://pkg.pr.new/jest-resolve@15768

jest-resolve-dependencies

npm i https://pkg.pr.new/jest-resolve-dependencies@15768

jest-runner

npm i https://pkg.pr.new/jest-runner@15768

jest-runtime

npm i https://pkg.pr.new/jest-runtime@15768

@jest/schemas

npm i https://pkg.pr.new/@jest/schemas@15768

jest-snapshot

npm i https://pkg.pr.new/jest-snapshot@15768

@jest/snapshot-utils

npm i https://pkg.pr.new/@jest/snapshot-utils@15768

@jest/source-map

npm i https://pkg.pr.new/@jest/source-map@15768

@jest/test-result

npm i https://pkg.pr.new/@jest/test-result@15768

@jest/test-sequencer

npm i https://pkg.pr.new/@jest/test-sequencer@15768

@jest/transform

npm i https://pkg.pr.new/@jest/transform@15768

@jest/types

npm i https://pkg.pr.new/@jest/types@15768

jest-util

npm i https://pkg.pr.new/jest-util@15768

jest-validate

npm i https://pkg.pr.new/jest-validate@15768

jest-watcher

npm i https://pkg.pr.new/jest-watcher@15768

jest-worker

npm i https://pkg.pr.new/jest-worker@15768

pretty-format

npm i https://pkg.pr.new/pretty-format@15768

commit: 12c8a48

Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Dates, how do they work?

@cpojer cpojer merged commit 81ac1bc into jestjs:main Aug 27, 2025
74 checks passed
@joshkel joshkel deleted the western-time-zone-test-fix branch August 27, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants