Skip to content

fix(jest-circus): handle undefined asyncError when test throws plain object #16008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JivinSardine wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

fix(jest-circus): handle undefined asyncError when test throws plain object #16008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/jest-circus/src/formatNodeAssertErrors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,17 @@ const formatNodeAssertErrors = (
error = asyncError;
} else if (originalError.stack) {
error = originalError;
} else {
} else if (asyncError) {
error = asyncError;

error.message =
originalError.message ||
`thrown: ${prettyFormat(originalError, {maxDepth: 3})}`;
} else {
error = new Error(
originalError.message ||
`thrown: ${prettyFormat(originalError, {maxDepth: 3})}`,
);
}
} else {
error = errors;
Expand Down
7 changes: 5 additions & 2 deletions packages/jest-circus/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,12 @@ const _getError = (
return error;
}

asyncError.message = `thrown: ${prettyFormat(error, {maxDepth: 3})}`;
if (asyncError) {
asyncError.message = `thrown: ${prettyFormat(error, {maxDepth: 3})}`;
return asyncError;
}

return asyncError;
return new Error(`thrown: ${prettyFormat(error, {maxDepth: 3})}`);
};

const getErrorStack = (error: Error): string =>
Expand Down
Loading