API helper methods & more styling options#72
Open
victorocna wants to merge 2 commits intojesusoterogomez:masterfrom
Open
API helper methods & more styling options#72victorocna wants to merge 2 commits intojesusoterogomez:masterfrom
victorocna wants to merge 2 commits intojesusoterogomez:masterfrom
Conversation
kbiedrzycki
reviewed
Apr 29, 2020
| top: defaults.top, | ||
| left: '0px', | ||
| textAlign: 'center', | ||
| right: defaults.right || '0px', |
Contributor
There was a problem hiding this comment.
Why did you get rid of width, margin and textAlign values?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Just used your npm package today for a project I'm currently working on. Really appreciate its simplicity compared to others. I would love to see the proposed changes implemented, IMO it would make the API better and would provide more options to position the toast (in my project I needed to position it to top-right).
Best,
Victor