[Services] Pass shutdown signals from Devbox to process-compose #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing for now until we can verify this is the issue |
|
Possibly related to F1bonacc1/process-compose#246. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR attempts to fix an issue where process-compose can terminate without cleaning up it's running processes. This occurs if you are running
devbox services upin a terminal, and then close the running terminal without first exiting process-compose.With this PR, Devbox will now explicitly propagate SIGTERM, SIGINT, SIGHUB, and SIGTSTP signals to process compose so it that it can run it's shutdown process and cleanup any running processes.
How was it tested?
devbox services upin a project that runs services