Skip to content

Conversation

mikeland73
Copy link
Contributor

@mikeland73 mikeland73 commented Sep 27, 2024

Summary

We're running out of Sentry events and it looks like the culprit is devbox overlogging, including a lot of user errors that should not be logged.

This PR #844 removed code that avoided logging user errors. I think this was a bug? If programmer wants a user error to be logged, they should use WithLoggedUserMessage instead.

How was it tested?

Untested

@mikeland73 mikeland73 requested a review from gcurtis September 27, 2024 05:23
@mikeland73 mikeland73 merged commit 6a72354 into main Sep 27, 2024
28 checks passed
@mikeland73 mikeland73 deleted the landau/dont-log-user-errors branch September 27, 2024 15:41
mikeland73 added a commit that referenced this pull request Oct 4, 2024
## Summary

Fixes bug introduced in #2305

## How was it tested?
maxcharm093 added a commit to maxcharm093/devbox that referenced this pull request Aug 24, 2025
## Summary

Fixes bug introduced in jetify-com/devbox#2305

## How was it tested?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants