-
Notifications
You must be signed in to change notification settings - Fork 269
[zeroconfig] Implement --autodetect flag #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"docker run --rm --mount type=volume,src=devbox-testscripts-amd64,dst=/nix --platform linux/amd64 -e DEVBOX_RUN_FAILING_TESTS -e DEVBOX_RUN_PROJECT_TESTS -e DEVBOX_DEBUG $image \"$@\"", | ||
], | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no concerns with the change. Seems a no-op, right?
Is there a setting or something that we can all use to align our tools?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
devbox does this automatically if I ever run any devbox command that mutates the config. I guess we haven't done that in a while in this repo.
import "context" | ||
|
||
type Detector interface { | ||
IsRelevant(path string) (float64, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we rename IsRelevant
to Score
, or if you'd like RelevancyScore
?
EDIT: Relevance() (float64, error)
also seems good
internal/boxcli/init.go
Outdated
}, | ||
} | ||
|
||
command.Flags().BoolVar(&flags.autoDetect, "autodetect", false, "Automatically detect packages to add") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts on just auto
?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## Summary closes DEV-153 Stacked on #2325 ## How was it tested?
## Summary closes DEV-153 Stacked on jetify-com/devbox#2325 ## How was it tested?
Summary
Closes DEV-151
(re) implements something similar to our old "planner" framework but only for python/poetry. It's only opt-in.
Using the
--autodetect
withinit
flag generates a devbox.json with any detection results.Currently the framework only only uses the most relevant detector, but could be modified to use multiple detectors.
How was it tested?
devbox init --autodetect --dry-run