nix: make internal/nix.cmd public #2473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jan 6, 2025
gcurtis
force-pushed
the
gcurtis/nix-cmd
branch
from
0f20410 to
1b0a61b
Compare
Move `internal/nix.cmd` and friends to the top-level nix package and export it. The constructor function is now a `Nix.Command` method. New commands use `Nix.Logger` for debug logs and include default arguments from `Nix.ExtraArgs`. As a convenience, the package-level `Command` function calls `Default.Command` (which uses the default Nix installation found in $PATH).
gcurtis
force-pushed
the
gcurtis/nix-cmd
branch
from
1b0a61b to
145b2ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
internal/nix.cmdand friends to the top-level nix package and export it.The constructor function is now a
Nix.Commandmethod. New commands useNix.Loggerfor debug logs and include default arguments fromNix.ExtraArgs.As a convenience, the package-level
Commandfunction callsDefault.Command(which uses the default Nix installation found in $PATH).