Skip to content

fix: pass a ctx to client searcher search #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix: pass a ctx to client searcher search #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/boxcli/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func searchCmd() *cobra.Command {
query := args[0]
name, version, isVersioned := searcher.ParseVersionedPackage(query)
if !isVersioned {
results, err := searcher.Client().Search(query)
results, err := searcher.Client().Search(cmd.Context(), query)
if err != nil {
return err
}
Expand Down
4 changes: 2 additions & 2 deletions internal/searcher/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func Client() *client {
}
}

func (c *client) Search(query string) (*SearchResults, error) {
func (c *client) Search(ctx context.Context, query string) (*SearchResults, error) {
if query == "" {
return nil, fmt.Errorf("query should not be empty")
}
Expand All @@ -43,7 +43,7 @@ func (c *client) Search(query string) (*SearchResults, error) {
}
searchURL := endpoint + "?q=" + url.QueryEscape(query)

return execGet[SearchResults](context.TODO(), searchURL)
return execGet[SearchResults](ctx, searchURL)
}

// Resolve calls the /resolve endpoint of the search service. This returns
Expand Down