fix(python plugin): remove UV_PYTHON env variable #2608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2575
The current python plugin sets
UV_PYTHONto path of python executable under defaultVENV_DIRdirectory. However if someone sets a customVENV_DIRin theirdevbox.jsonfile, this will cause an error. Sinceuvwill attempt and fail to find python in the default VENV_DIR path where the venv would no longer exist.This change removes the
UV_PYTHONenvironment variable from the plugin altogether. This can be done, sinceuvwill use the python executable of the active virtual environment its running in (https://docs.astral.sh/uv/reference/cli/#uv-python), and the venv is automatically created and activated by the python plugin.This change allows flexibility for users to set their own
VENV_DIR. It also still works with pip (uv pip install) as expected.How was it tested?
"VENV_DIR": "./src/uvtest/.venv"toenvsection ofdevbox.jsonfileuv run main.py: (this step would cause an error before these changes)uv pip install fastapiCommunity Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.