-
Notifications
You must be signed in to change notification settings - Fork 269
[compliance] Update dependencies in devbox #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update dependencies in devbox examples - Update dependencies in our go code - Update tools referenced by go.mod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependencies across the devbox codebase to ensure compliance with the latest versions. The changes focus on bumping version numbers for Go dependencies, Ruby gems, and Node.js packages used in various examples and tools.
- Updated Go module dependencies including AWS SDK, tablewriter, and numerous linting/analysis tools
- Updated Rails version in the blog example from 7.0.8 to 7.1.5
- Updated documentation app dependencies including React, TypeScript, and OpenAPI docs plugins
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
internal/boxcli/auth.go | Updated tablewriter API usage to use new Bulk method instead of deprecated AppendBulk |
go.mod | Comprehensive update of Go dependencies and tools to latest versions |
examples/stacks/rails/blog/Gemfile | Updated Rails version from 7.0.8 to 7.1.5 |
docs/app/package.json | Updated Node.js dependencies including React, TypeScript, and documentation plugins |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
table := tablewriter.NewWriter(cmd.OutOrStdout()) | ||
table.SetRowLine(true) | ||
table.AppendBulk([][]string{ | ||
// Row lines are configured through the renderer in the new API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment explains the removal of SetRowLine but doesn't explain what the new renderer configuration would look like or where it should be configured. Consider adding more context about how row lines are now configured in the new API.
// Row lines are configured through the renderer in the new API | |
// To configure row lines (horizontal lines between rows) in the new API, | |
// use table.SetRowLine(true) before rendering. The SetRowLine method controls | |
// whether horizontal lines are drawn between table rows. For more customization, | |
// refer to the tablewriter documentation: https://pkg.go.dev/github.com/olekukonko/tablewriter |
Copilot uses AI. Check for mistakes.
## Summary Docusaurus was failing to start due to an incompatible upgrade in #2684: `Module not found: Error: Can't resolve '@theme/ResponseSamples'` Also updated README to reflect new tooling. Finally, I tried to fix the local `pnpm start` opening to `localhost:3000/docs/devbox` but didn't succeed for now. Left a note in the README to alert developers about it. **Upgrade Fix** - The component name changed from ResponseSamples to ResponseExamples, but more importantly, the component API also changed: - Old (v4.4.0): ``` import ResponseSamples from "@theme/ResponseSamples"; <ResponseSamples responseExample={"{\n \"query\": \"string\", ...}"} language={"json"} /> ``` - New (v4.5.1): The new version uses a completely different component structure - it no longer uses ResponseSamples or ResponseExamples directly in the generated MDX. Instead, it uses a different set of components like StatusCodes, RequestSchema, etc. ``` # Regenerate the API docs from the OpenAPI spec pnpm docusaurus gen-api-docs nixhub # Move the regenerated files to the correct location cp docs/nixhub/*.api.mdx nixhub/ # Clean up the temporary directory rm -rf docs/nixhub ``` Files Updated - nixhub/search-packages.api.mdx - nixhub/resolve-a-package-version.api.mdx - nixhub/get-a-package.api.mdx These files now use the updated component structure compatible with docusaurus-theme-openapi-docs v4.5.1. ## How was it tested? `devbox run start` and opened devbox docs as well as the Nixhub docs. `devbox run build` and `devbox run serve` and opened the docs again in localhost, just to be safe and ensure the production environment will work in Vercel. ## Community Contribution License All community contributions in this pull request are licensed to the project maintainers under the terms of the [Apache 2 License](https://www.apache.org/licenses/LICENSE-2.0). By creating this pull request, I represent that I have the right to license the contributions to the project maintainers under the Apache 2 License as stated in the [Community Contribution License](https://github.com/jetify-com/opensource/blob/main/CONTRIBUTING.md#community-contribution-license).
Summary
devbox update
to update the nix dependenciesHow was it tested?
Ran all tests
Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.