Added support for ZDOTDIR handling in Zsh shell initialization. #2712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jetify-com#1715 jetify-com#2297 This commit adds a patch to correctly handle ZDOTDIR env var for zsh. Instead of copying .z* files directly, we now source them inside devbox zsh config after setting ZDOTDIR to user's config dir. This makes sure any user config referencing ZDOTDIR doesn't break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1715 #2297
This commit adds a patch to correctly handle ZDOTDIR env var for zsh. Instead of copying .z* files directly, we now source them inside devbox zsh config after setting ZDOTDIR to user's config dir. This makes sure any user config referencing ZDOTDIR doesn't break.
How was it tested?
Unit tests and manual testing
Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.