Skip to content

Conversation

alexevladgabriel
Copy link
Contributor

@alexevladgabriel alexevladgabriel commented Jan 7, 2025

Changelogs:

  • Includes workflows for creating binaries on new releases and pr's for being able to test them.

Workflows:

  • Release
  • Push

@alexevladgabriel alexevladgabriel marked this pull request as draft January 7, 2025 23:07
@Nevexo
Copy link
Contributor

Nevexo commented Jan 7, 2025

Just so it's in the GH history: Discord Thread

PR builds should include the commit hash of the latest commit in the PR's branch

@kashalls
Copy link

kashalls commented Jan 7, 2025

Can you pass both a Version and a Gitsha instead of just the ref?

go build -ldflags "-s -w -X kvm.Version=${VERSION} -X kvm.Gitsha=${REVISION}" ./cmd/main.go

Version is the Semver Tag and Gitsha is the sha of the git commit it is building on.

@alexevladgabriel alexevladgabriel marked this pull request as ready for review January 8, 2025 00:53
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

GOOS: ${{ matrix.goos }}
GOARCH: ${{ matrix.goarch }}
run: |
GOOS=linux GOARCH=arm GOARM=7 go build -ldflags="-s -w -X kvm.builtAppVersion=dev-${GIT_COMMIT:0:7}" -o bin/jetkvm_app cmd/main.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've entered the matrix, then this line should use it :)

GOOS=${matrix.goos} GOARCH=${matrix.goarch} GOARM=7 go build -ldflags="-s -w -X kvm.builtAppVersion=dev-${GIT_COMMIT:0:7}" -o bin/jetkvm_app cmd/main.go

@IDisposable
Copy link
Contributor

Might it be better to execute the Makefile instead duplicating the one line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants