enable spelling linters and fix spelling mistakes

Signed-off-by: Tim Ramlot <[email protected]>

Author: inteon

pkg/agent/config.go

@@ -350,7 +350,7 @@ func InitAgentCmdFlags(c *cobra.Command, cfg *AgentCmdFlags) {
 }
 
 // TLSPKMode controls how to authenticate to TLSPK / Jetstack Secure. Only one
-// TLSPKMode may be provided if using using those backends.
+// TLSPKMode may be provided if using those backends.
 type TLSPKMode string
 
 const (

pkg/agent/config_test.go

@@ -634,7 +634,7 @@ func Test_ValidateAndCombineConfig(t *testing.T) {
 		assert.Equal(t, true, got.MachineHubMode)
 	})
 
-	t.Run("machinehub + venafi-cloud-keypair-auth should work simultanously", func(t *testing.T) {
+	t.Run("machinehub + venafi-cloud-keypair-auth should work simultaneously", func(t *testing.T) {
 		t.Setenv("POD_NAMESPACE", "venafi")
 		t.Setenv("KUBECONFIG", withFile(t, fakeKubeconfig))
 		privKeyPath := withFile(t, fakePrivKeyPEM)

pkg/internal/cyberark/identity/advance_authentication_test.go

@@ -24,7 +24,7 @@ func Test_IdentityAdvanceAuthentication(t *testing.T) {
 				MechanismID:     successMechanismID,
 				SessionID:       successSessionID,
 				TenantID:        "foo",
-				PersistantLogin: true,
+				PersistentLogin: true,
 			},
 
 			expectedError: nil,
@@ -37,7 +37,7 @@ func Test_IdentityAdvanceAuthentication(t *testing.T) {
 				MechanismID:     successMechanismID,
 				SessionID:       successSessionID,
 				TenantID:        "foo",
-				PersistantLogin: true,
+				PersistentLogin: true,
 			},
 
 			expectedError: fmt.Errorf(`got a failure response from request to advance authentication: message="Authentication (login or challenge) has failed. Please try again or contact your system administrator.", error="aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee:55555555555555555555555555555555"`),
@@ -50,7 +50,7 @@ func Test_IdentityAdvanceAuthentication(t *testing.T) {
 				MechanismID:     successMechanismID,
 				SessionID:       successSessionID,
 				TenantID:        "foo",
-				PersistantLogin: true,
+				PersistentLogin: true,
 			},
 
 			expectedError: fmt.Errorf(`got a failure response from request to advance authentication: message="Authentication (login or challenge) has failed. Please try again or contact your system administrator.", error="aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee:55555555555555555555555555555555"`),
@@ -63,7 +63,7 @@ func Test_IdentityAdvanceAuthentication(t *testing.T) {
 				MechanismID:     "foo",
 				SessionID:       successSessionID,
 				TenantID:        "foo",
-				PersistantLogin: true,
+				PersistentLogin: true,
 			},
 
 			expectedError: fmt.Errorf(`got a failure response from request to advance authentication: message="Authentication (login or challenge) has failed. Please try again or contact your system administrator.", error="aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee:55555555555555555555555555555555"`),
@@ -76,20 +76,20 @@ func Test_IdentityAdvanceAuthentication(t *testing.T) {
 				MechanismID:     successMechanismID,
 				SessionID:       "foo",
 				TenantID:        "foo",
-				PersistantLogin: true,
+				PersistentLogin: true,
 			},
 
 			expectedError: fmt.Errorf(`got a failure response from request to advance authentication: message="Authentication (login or challenge) has failed. Please try again or contact your system administrator.", error="aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee:55555555555555555555555555555555"`),
 		},
-		"persistant login not set": {
+		"persistent login not set": {
 			username: successUser,
 			password: []byte(successPassword),
 			advanceBody: advanceAuthenticationRequestBody{
 				Action:          ActionAnswer,
 				MechanismID:     successMechanismID,
 				SessionID:       successSessionID,
 				TenantID:        "foo",
-				PersistantLogin: false,
+				PersistentLogin: false,
 			},
 
 			expectedError: fmt.Errorf("got unexpected status code 403 Forbidden from request to advance authentication in CyberArk Identity API"),

pkg/internal/cyberark/identity/identity.go

@@ -156,9 +156,9 @@ type advanceAuthenticationRequestBody struct {
 	// get the Identity API URL, but we set it anyway to be explicit.
 	TenantID string `json:"TenantId"`
 
-	// PersistantLogin is documented to "[indicate] whether the session should persist after the user
+	// PersistentLogin is documented to "[indicate] whether the session should persist after the user
 	// closes the browser"; for service-to-service auth which we're trying to do, we set this to true.
-	PersistantLogin bool `json:"PersistantLogin"`
+	PersistentLogin bool `json:"PersistentLogin"`
 }
 
 // advanceAuthenticationResponseResult is the specific information returned for a successful AdvanceAuthentication call
@@ -370,7 +370,7 @@ func (c *Client) doStartAuthentication(ctx context.Context, username string) (ad
 	response.MechanismID = mechanism.MechanismID
 	response.SessionID = startAuthResponse.Result.SessionID
 	response.TenantID = c.subdomain
-	response.PersistantLogin = true
+	response.PersistentLogin = true
 
 	return response, nil
 }

pkg/internal/cyberark/identity/mock.go

@@ -189,11 +189,11 @@ func (mis *mockIdentityServer) handleAdvanceAuthentication(w http.ResponseWriter
 	// Important: The actual server will return 200 OK even if the login fails.
 	// Most failure responses should copy that.
 
-	if !advanceBody.PersistantLogin {
+	if !advanceBody.PersistentLogin {
 		// this is something we enforce but wouldn't actually be an error from
 		// a real server, so we return a different error here
 		w.WriteHeader(http.StatusForbidden)
-		_, _ = w.Write([]byte(`expected PersistantLogin to be true`))
+		_, _ = w.Write([]byte(`expected PersistentLogin to be true`))
 		return
 	}
 

pkg/internal/cyberark/identity/start_authentication_test.go

@@ -88,8 +88,8 @@ func Test_IdentityStartAuthentication(t *testing.T) {
 				t.Errorf("expected advanceAuthenticationRequestBody.Action to be %s but got %s", ActionAnswer, advanceBody.Action)
 			}
 
-			if !advanceBody.PersistantLogin {
-				t.Error("expected advanceAuthenticationRequestBody.PersistantLogin to be true but it wasn't")
+			if !advanceBody.PersistentLogin {
+				t.Error("expected advanceAuthenticationRequestBody.PersistentLogin to be true but it wasn't")
 			}
 
 		})